toolCHAINZ / jingle

SMT Modeling for Ghidra's PCODE
MIT License
8 stars 1 forks source link

Move jingle_sleigh into separate crate #4

Closed chf0x closed 2 months ago

chf0x commented 2 months ago

Hi! Do you think it would be beneficial to move jingle_sleigh into a separate crate? This way, people who only need the pcode bindings would not have to add unused libraries to their projects

toolCHAINZ commented 2 months ago

Hi again!

So, jingle_sleigh already is in its own crate, as this repo is set up as a Cargo Workspace.

If you're using a git dependency on it, you can point it at this repo but depend on jingle_sleigh instead of jingle.

I also have them both published on crates.io though the version on there is out of date from the dev branch. I'm depending on some APIs in the z3 crate that are not yet on crates.io so I can't push the dev branch until z3.rs pushes an update. And z3.rs is waiting on the next upstream z3 release to fix a bug 🫠 . Someday haha

chf0x commented 2 months ago

Ah, sorry. I am relatively new to Rust and haven't learned all the package manager features yet. It turns out it was sufficient to add:

jingle_sleigh = { git = "ssh://git@github.com/toolCHAINZ/jingle", branch = "dev", package = "jingle_sleigh" }

Thank you for the help!