toolboc / psx-pi-smbshare

A swiss army knife for enhancing classic game consoles with Raspberry Pi
387 stars 34 forks source link

USB Mounts are not setup with folder structure #4

Closed the8thsign closed 5 years ago

the8thsign commented 5 years ago

When a USB Drive is mounted, there should be a check to see if the correct folder structure is there and if it is not, create all the necessary folders as seen in https://github.com/toolboc/psx-pi-smbshare/blob/master/Assets/smbshare.PNG

toolboc commented 5 years ago

As-is, the appropriate folder structures will be created for you when OPL / Multiman successfully connect to the mounted USB drive for the first time (assuming there is no write protection on the drive).

Can you confirm whether the above behavior is working as intended? If it is not, I am happy to investigate a fix later this week.

Thank you!

Clydefrosch22 commented 5 years ago

Slight suspicion, but what's your storage file system? (Like fat32, ntfs etc)

the8thsign commented 5 years ago

Yes, OPL did make the correct folders once I connected. Haven't connected to Multiman so I can't say for sure but I'm sure it would work also.

toolboc commented 5 years ago

Excellent!

Apologies for this not being obvious.

Do you have any suggestions to make this more obvious to other users? I am worried that if it was an issue for you that it may also be an issue for others.

I would be happy to accept a PR that explains this behavior clearly in the README if you think it would assist.

Let me know what you think, then we can probably close the issue.

Thanks again!

toolboc commented 5 years ago

closed

Functionality already provided when connecting to OPL / Multiman for first time.

ITotalJustice commented 5 years ago

Just to add, when connecting a ntfs hdd, no folders are created even when connecting to multiman. The hdd is succesfully mounted to /media and shows in windows when doing \SMBSHARE\share. However the ps3 still uses the /share folder thats on the sd card. So dumping games to the server simply saves it to the sd card. And when creating all the folders manually, still the /share sd card storage is used instead of the ntfs hdd.

Not sure if you want me to open a new issue on this?

toolboc commented 5 years ago

@ITotalJustice, thank you for reporting the issue, it looks like the issue you are describing snuck in the previous release when I performed an update to the underlying Raspbian base image which caused some issues with pmount that went unnoticed. I was able to resolve the issue by re-running setup.sh which in effect rebuilt pmount from source and linked with the updated system modules.

I can confirm that NTFS drives are now working as expected and that Multiman will create the appropriate folder paths when connected (PSXISO and PS2ISO will create upon ripping a respective disc):

image

To apply these fixes you can update an existing installation by running the setup.sh located in the home directory via an ssh session, or reflash your SD card with the latest v1.7 release.

Apologies for any inconvenience this blip may have caused!

ITotalJustice commented 5 years ago

@ITotalJustice, thank you for reporting the issue, it looks like the issue you are describing snuck in the previous release when I performed an update to the underlying Raspbian base image which caused some issues with pmount that went unnoticed. I was able to resolve the issue by re-running setup.sh which in effect rebuilt pmount from source and linked with the updated system modules.

I can confirm that NTFS drives are now working as expected and that Multiman will create the appropriate folder paths when connected (PSXISO and PS2ISO will create upon ripping a respective disc):

image

To apply these fixes you can update an existing installation by running the setup.sh located in the home directory via an ssh session, or reflash your SD card with the latest v1.7 release.

Apologies for any inconvenience this blip may have caused!

I completely missed your reply (and quick fix!) until now! Thank you very much