search

toolboc / psx-pi-smbshare

A swiss army knife for enhancing classic game consoles with Raspberry Pi
387 stars 34 forks source link

Prevent override of smb.conf on start #54

Open arthurdenner opened 1 year ago

arthurdenner commented 1 year ago

Hey there, thanks for this project, it's been very useful for me!

As I learnt more about the Raspberry Pi ecosystem, I started to tweak the configuration files, including the /etc/samba/smb.conf to add more shared folders. However, upon restart, the config is overwritten by the automount-usb.sh or samba-init.sh scripts (depending on the setup running). I was able to "workaround" this by modifying these files on my own Pi.

I was wondering if it'd be safe not to override the /etc/samba/smb.conf file if it exists and log about it as the default behaviour.

If you're interested, I can try to contribute to the change as an opportunity to learn and for the Hacktoberfest event.

toolboc commented 1 year ago

This would be a rad feature and would totally accept if you decide to pursue this.