search

toolbox-team / reddit-moderator-toolbox-legacy

LEGACY VERSION do not use
http://www.reddit.com/r/toolbox
Apache License 2.0
66 stars 40 forks source link

Removal reasons: markdown links within <option> aren't included #295

Open TheEnigmaBlade opened 10 years ago

TheEnigmaBlade commented 10 years ago

For an example, here's a shortened version of the /r/leagueoflegends removal reasons:

Your post has been removed because 
*<select id="subreddit_rules_combobox"> 
<option>witch hunting is not allowed. Please read [this wiki page](/r/leagueoflegends/w/witchhunting) for more information.</option>
<option>tech support questions and requests are not allowed. [Contact Riot support](https://support.leagueoflegends.com/anonymous_requests/new) if you have not already done so.</option>
</select>*

If you are not familiar with the subreddit rules, you can read them [here](/r/leagueoflegends/w/subredditrules).

The link to the subreddit rules at the end is included in the commented/PM'd removal reason, but all links in option tags are not included.

creesch commented 10 years ago

Isn't this the issue where you simply need to double escape something?

If you want links in your selection box, you will need to put a forward slash '\' in front of every bracket, except for the closing parenthesis ')', as having the \ in there messes up the link.

<option>\[Option 1\]\(http://www.reddit.com)</option>

I guess we could do a check for markdown between option tags and escape stuff... Not sure if that is really needed though.

agentlame commented 9 years ago

Where are we on this? If it's a bug it need confirmed and a milestone.