search

toolbox-team / reddit-moderator-toolbox-legacy

LEGACY VERSION do not use
http://www.reddit.com/r/toolbox
Apache License 2.0
66 stars 40 forks source link

Organize flairs #710

Open jdf221 opened 8 years ago

jdf221 commented 8 years ago

Maybe organize isn't the right word but what ever.

I have 30+ link flairs and sometimes I need to add a flair in the middle of them all. (That way when selecting a flair people don't have to go hunting for the flair. It's in the same place as the other ones like it are.)

The only way for me to do this is by adding a new flair and moving all the existing ones down. This takes a long time and is very frustrating.

It would be nice to be able to just drag and drop the flairs to where I want them. Or just be able to click add beneath an existing flair.

TheEnigmaBlade commented 8 years ago

I've thought about a feature like this for a long time because I frequently add new flair to /r/leagueoflegends, which has hundreds of flair. The problem is it would have to do exactly what you do manually, which isn't exactly a good method. As useful of a feature as it would be, it suffers from usability issues (having to wait 15 minutes to move a flair) only fixable by the admins or anyone willing to create a pull request.

jdf221 commented 8 years ago

15 minutes?

When does it limit you to 15 minutes? I haven't been limited yet? It does limit me for about 2 seconds each time I save a flair though.

agentlame commented 8 years ago

reddit has ratelimits for API actions. So you could end up hitting one and have to wait for 10 mins.

But that's not the only issue. If reddit were to take a shit (as it is want to do) while the mass reordering is happening in the background, you could loose all your flairs.

Keep in mind, as implemented, this feature would be a simple drag action for the user. Behind the scenes toolbox would be deleting and creating every flair again. So if you move a flair up 20 spots, toolbox would have to delete and create 20 flairs. That's 40 API calls. (Actually, it's 42, but who's counting?)

TheEnigmaBlade commented 8 years ago

When does it limit you to 15 minutes?

I'm using this as a example use case based on the only subreddit in which I would use the feature: /r/leagueoflegends. There, flair is split into two groups, and each group is around 130 flair in size. The first group is kept in alphabetical order and is the one most frequently modified. In the best case — new flair starting with Z — only 130 flair have to be removed and re-added for a run time of 8.7 minutes at the required rate limit of 2 seconds. In the worst case — new flair starting with A — around 260 flair have to be removed and re-added, resulting in an impressive 17.4 minute run time. The average is about 13 minutes.

jdf221 commented 8 years ago

I would be fine with waiting, but I do understand how it would be a problem. And see why this wouldn't be added.