toolbox-team / reddit-moderator-toolbox-legacy

LEGACY VERSION do not use
http://www.reddit.com/r/toolbox
Apache License 2.0
66 stars 40 forks source link

Usernotes are broken when accessed from a subreddit-filtered user page #790

Closed eritbh closed 7 years ago

eritbh commented 7 years ago

Per this thread because I actually never got around to looking at it myself.

If you use the "search by subreddit" feature in a user page, and then click the user notes dialog on any resulting post or comment, it doesn't work. I assume this is because the search result things aren't being constructed with the relevant data- attributes for author and/or subreddit. Could be wrong though, haven't looked at any code.

creesch commented 7 years ago

Oh that is entirely possible. We reconstruct the comment structure there but that format might be outdated.

I was thinking about the other day actually, sometimes I wonder if it isn't "easier" to get the actual pages instead of going through the api so we can always be sure we have the correct html structure of the comments. The data overhead would be considerably more though I guess...

So it is probably better to update our templates :)