search

toolbox-team / reddit-moderator-toolbox

Moderator toolbox for reddit extension development.
https://www.reddit.com/r/toolbox
Apache License 2.0
114 stars 38 forks source link

If user has usernote show button next to name, even if hovercard setting is enabled. #110

Open creesch opened 5 years ago

creesch commented 5 years ago

https://old.reddit.com/r/toolbox/comments/c22lv5/user_notes_on_new_reddit/

So if there are no usernotes we don't show the button as well.

And for clarity, this obviously only applies to redesign reddit.

creesch commented 5 years ago

Moving this to 5.3, this requires a bunch more effort than I anticipated and would need proper testing.

The issue is that we first add the buttons and then process them all at once, which works fine except if we want to implement something like this.

The only easy solution I can think of right now is to still add the usernote button when queueProcessSub is enabled but hide it and then when we populate notes show them. This does add a bit of unneeded overhead though as we still add the element to each item.

So I am going to reconsidering our options here and push it to the next release.