toolbox4minecraft / amidst

Advanced Minecraft Interface and Data/Structure Tracking
GNU General Public License v3.0
2.14k stars 240 forks source link

Large biome worlds displaying as default #800

Closed hjpoe closed 4 years ago

hjpoe commented 4 years ago

Hello,

I don't know if this is a known error or not, and I didn't see it in the issues, so I thought I'd post it.

One of the worlds I'm playing should look like this (I think I made it large biome, but I'm never 100% sure).

image

I'm currently at that village on the island at ~2100 ~40. When I open the world save in amidst, it shows me this map with me in the middle of the ocean.

image

machinesmith42 commented 4 years ago

currently out of scope?

hjpoe commented 4 years ago

It doesn't seem like it should be out of scope. Wouldn't you just have to make the existing map bigger? I could help if I knew what to do, I have experience in Java.

On Thu, Jul 2, 2020, 10:35 AM machinesmith42 notifications@github.com wrote:

currently out of scope?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/toolbox4minecraft/amidst/issues/800#issuecomment-653043065, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIPPIHD5REVUL7YG3KIKAT3RZSLLBANCNFSM4OOLH46Q .

burgerindividual commented 4 years ago

Large biomes is definitely within the scope of amidst considering that deliberate decisions were made in the code to allow it. I’ll take a look at it later when I get the chance to see what’s wrong with it.

hjpoe commented 4 years ago

Thanks, I thought that they would still be supported. If there's anything I can do to help, please let me know. I'm not very familiar with your code because I haven't read through it yet, but I can program.

On Thu, Jul 2, 2020, 12:15 PM burgerguy notifications@github.com wrote:

Large biomes is definitely within the scope of amidst considering that deliberate decisions were made in the code to allow it. I’ll take a look at it later when I get the chance to see what’s wrong with it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/toolbox4minecraft/amidst/issues/800#issuecomment-653100233, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIPPIHAMI3MTKAUQH5TFZYLRZSXCTANCNFSM4OOLH46Q .

burgerindividual commented 4 years ago

Here are two screenshots with the same zoom and the same seed, one set to large biomes:

Default: screenshot_default_-703112092150021424

Large Biomes: screenshot_large-biomes_-703112092150021424

Are you sure that you enabled large biomes when typing in the seed? It seems to work fine on the latest version of amidst.


Also, if you want to help out with programming you can read the wiki for how to get started. As for becoming familiar with the amidst codebase, you really just need to read through it all and start working with it. Knowing how everything interacts with each other comes over time. I'm not really the best person to ask for what you can do at the moment, but you could ask @moulins and he would be able to help.

hjpoe commented 4 years ago

I know Amidst can show a large biome world from the seed. My problem is with opening a save game.

My first screenshot was opened new from seed. The issue is when I opened the world via open save game, it shows it as default biome size, when I am clearly not in the ocean, as I (was) at a village. I'm not 100% positive that I selected large biome size, but evidence seems to point that way. I have the latest version of Amidst.

Thanks for the information, I'll look at the wiki.

burgerindividual commented 4 years ago

@hjpoe I looked into it and found the issue. I just made a pull request fixing it and that should be getting merged at some point.