search

toolbx-images / images

Community maintained container images to use with toolbx and distrobox
https://containertoolbx.org/
Apache License 2.0
342 stars 30 forks source link

Ubuntu: Added flatpak-xdg-utils to extra-packages and linked flatpak-spawn to /usr/bin #40

Closed Plamper closed 2 years ago

Plamper commented 2 years ago

This allows toolbox-vscode to work with the Ubuntu Containers. The package was introduced in version 20.04, that's why there is no changes on 16.04 and 18.04.

Plamper commented 2 years ago

In https://github.com/toolbx-images/images/pull/39 you mentioned that having less RUN statements, would generally be better. I could adjust this so it would not use a separate RUN command for the symlink. Let me know if I should change that.

travier commented 2 years ago

What I meant in that PR is that I think that we should try to have as small images as possible and when doing package operations, that means using a single layer to be able to cleanup metadata after.

In this case, this likely has minor impact on image size and only adds a small layer so I'd say this is fine as is.