Consider removing NAME and VERSION variables

toolbx-images / images

Community maintained container images to use with toolbx and distrobox

https://containertoolbx.org/

Apache License 2.0

323 stars 29 forks source link

Consider removing NAME and VERSION variables #50

Closed Jmennius closed 1 year ago

Jmennius commented 1 year ago

This was previously discussed in containers/toolbox#188. Those variables are not required for non-Fedora images as it is only used by OSBS to build Fedora images. Otherwise, they just pollute user environment and the upstream project got a few complaints about that.

I suggest we remove them as thy provide no value (that is not otherwise covered by labels) and cause some annoyance.

travier commented 1 year ago

If toolbox does not need them then let's do it 👍🏻