search

toolbx-images / images

Community maintained container images to use with toolbx and distrobox
https://containertoolbx.org/
Apache License 2.0
323 stars 29 forks source link

alpine: Remove NAME and VERSION variables #59

Closed castrojo closed 1 year ago

castrojo commented 1 year ago

As per recommendations in #50

travier commented 1 year ago

You should remove the ENV vars but keep the labels

travier commented 1 year ago

You need to move the names and version into the labels as we don't set the env now.

travier commented 1 year ago

See https://github.com/toolbx-images/images/commit/0b1e5ab89bc112dbfaea33793e8c0bbcc5716de0 for an example

castrojo commented 1 year ago

Wow that was embarrassing, ok PTAL.

travier commented 1 year ago

Sorry one last nit