search

toolbx-images / images

Community maintained container images to use with toolbx and distrobox
https://containertoolbx.org/
Apache License 2.0
333 stars 30 forks source link

ubuntu: Add libcap2-bin for capsh #74

Closed travier closed 1 year ago

travier commented 1 year ago

Fixes: https://github.com/toolbx-images/images/issues/73

Jmennius commented 1 year ago

Should we put it into the container file itself since it is essential to the image (not just extra)?

travier commented 1 year ago

This file is used during the container build to include the package in the container.

travier commented 1 year ago

https://github.com/toolbx-images/images/blob/main/ubuntu/18.04/Containerfile#L28

Jmennius commented 1 year ago

This file is used during the container build to include the package in the container.

What I mean is - add it directly to the Containerfile - same install command but explicitly on the command line there. Because packages listed in extra-packages are supposed to be 'extra' as the name suggests (i.e. optional) and one can expect to clean this file and the image to still be functional (which it won't be, without capsh).

travier commented 1 year ago

We don't split between "mandatory" and "extra" packages as far as I know.

travier commented 1 year ago

Feel free to make a PR to create that split :)

Jmennius commented 1 year ago

We don't split between "mandatory" and "extra" packages as far as I know.

I consider whatever we install in the Containerfile to be required for the image to function, by this logic - there is a split already :) For example, ubuntu-minimal, ubuntu-standard and libnss-myhostname installed there are mandatory.

Jmennius commented 1 year ago

Opened #75 which reverts this partially (not the sort).

debarshiray commented 1 year ago

For example, ubuntu-minimal, ubuntu-standard and libnss-myhostname installed there are mandatory.

The Git history says that /usr/local/sbin/unminimize, ubuntu-minimal and ubuntu-standard were removed from ubuntu-toolbox:18.04 in commit 5cbaecde2f30ea1d to fix the build.

Jmennius commented 1 year ago

For example, ubuntu-minimal, ubuntu-standard and libnss-myhostname installed there are mandatory.

The Git history says that /usr/local/sbin/unminimize, ubuntu-minimal and ubuntu-standard were removed from ubuntu-toolbox:18.04 in commit 5cbaecde2f30ea1d to fix the build.

I'm curious what happened there.. but it has worked before that and it works now (unminimizing and installing ubuntu-minimal and ubuntu-standard metapackages; plus other container are just like this). Hopefully it was just an intermittent failure...