tooling / book-of-modern-frontend-tooling

The Front-end Tooling Book
http://tooling.github.io/book-of-modern-frontend-tooling/
2.53k stars 177 forks source link

changes to gulp-parse-toc.js to build on windows #45

Closed stombeur closed 10 years ago

stombeur commented 10 years ago

I wasn't able to build the output on windows 8.1 When loading the toc.md the path separators were windows-style, so the file path wasn't split correctly when using '/'. Next up when reading the .md files and linking to other files, the '/' was always used, but matched paths on disk were using the '\'

This now builds the pdf and the site at least. As I don't fully understand yet how files are pushed into the gulp-parse-toc.js plugin, I suppose this is not the best way to do it but I'm not sure how to fix it more elegantly.

changes

michealbenedict commented 10 years ago

Thanks @stombeur for testing this on Windows. This patch looks good to me. @sindresorhus @addyosmani comments? If this looks good, can we merge this in?