search

tooling / book-of-modern-frontend-tooling

The Front-end Tooling Book
http://tooling.github.io/book-of-modern-frontend-tooling/
2.53k stars 177 forks source link

Browserify: Writing Modules #52

Closed jackfranklin closed 9 years ago

jackfranklin commented 10 years ago

First part of the writing modules chapter. By no means finished yet!

addyosmani commented 10 years ago

Thanks @jackfranklin! Would you like us to review and land this first piece or keep this open for you to push further commits to?

jackfranklin commented 10 years ago

I would keep it open for now, hoping to get a bit more up today (sorry, in the future I'll be more clear and only open a PR when I think it's ready!).

jackfranklin commented 10 years ago

@addyosmani slowest pull request ever! So sorry. I have added some more and I'd say this bit is at a reviewable stage.

addyosmani commented 10 years ago

@jackfranklin This looks good. Do you think you'll have time over the next few weeks to take another look at fleshing this out some more? Do you want us to keep this PR open?

jackfranklin commented 10 years ago

Should have some time in the next couple of days - so feel free to leave comments on the content so far and I'll get some more written tonight / tomorrow to try to maybe finish this chapter off.

addyosmani commented 9 years ago

Friendly ping :)

jackfranklin commented 9 years ago

@addyosmani thanks! sorry as always. Will get some more done asap

addyosmani commented 9 years ago

Thanks Jack!

addyosmani commented 9 years ago

Shall we try landing this and marking as WIP or continue to keep open in case you get a little time to continue fleshing this out? :)

jackfranklin commented 9 years ago

@addyosmani let's land and mark as WIP - clearly time is against me at the moment :(