toolkit-for-ynab / toolkit-for-ynab

A general purpose YNAB enhancing browser extension for Chrome and Firefox. Have it your way!
MIT License
1.44k stars 346 forks source link

Net Worth Chart Doesn't Total Right #2699

Closed tkemp6 closed 9 months ago

tkemp6 commented 2 years ago

My total assets and the total debt in the net worth report don't add up to the total of assets or debt in my accounts. Not using exact numbers, but if I have credit card debt of 1,000 and a mortgage of 150,000, the debt in my net worth report doesn't total 151,000

portsauthority commented 2 years ago

This may be the same issue as https://github.com/toolkit-for-ynab/toolkit-for-ynab/issues/2611 where for mortgage accounts the net worth is including the interest/escrow in debt payoff, rather than just using the principal amount.

michaelcmelton commented 2 years ago

@tkemp6 @portsauthority Can you confirm if this is still an issue with v3.2.1? I can't get it to reproduce.

tkemp6 commented 2 years ago

Yes, I'm still getting the same issue. My mortgage balance is more than what my debts show as on the net worth chart.

On Fri, Jun 17, 2022 at 9:01 PM michaelcmelton @.***> wrote:

@tkemp6 https://github.com/tkemp6 @portsauthority https://github.com/portsauthority Can you confirm if this is still an issue with v3.2.1? I can't get it to reproduce.

— Reply to this email directly, view it on GitHub https://github.com/toolkit-for-ynab/toolkit-for-ynab/issues/2699#issuecomment-1159326032, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHSC5TFBRWBWR2NG5ZNBKXTVPUNVBANCNFSM5RAQVDTQ . You are receiving this because you were mentioned.Message ID: @.***>

michaelcmelton commented 2 years ago

@tkemp6 Can you give us a settings export to try and reproduce it?

tkemp6 commented 2 years ago

[{"key":"AccountsDisplayDensity","value":"2"},{"key":"AccountsEmphasizedInflows","value":true},{"key":"AccountsEmphasizedOutflows","value":true},{"key":"AccountsStripedRows","value":true},{"key":"AccountsStripedRowsColor","value":"#fafafa"},{"key":"AccountsStripedRowsDarkColor","value":"#1e1e1f"},{"key":"AssistedClear","value":true},{"key":"AutoDistributeSplits","value":false},{"key":"AutoEnableRunningBalance","value":true},{"key":"AutomaticallyMarkAsCleared","value":false},{"key":"BetterScrollbars","value":"1"},{"key":"BottomNotificationBar","value":false},{"key":"BudgetCategoryFeatures","value":true},{"key":"BudgetProgressBars","value":"0"},{"key":"BudgetQuickSwitch","value":true},{"key":"BudgetSpendingGoal","value":false},{"key":"BulkEditMemo","value":true},{"key":"BulkManagePayees","value":true},{"key":"CalculateIRR","value":"Yellow"},{"key":"CalendarFirstDay","value":"0"},{"key":"CategoryActivityCopy","value":false},{"key":"CategoryActivityPopupWidth","value":"0"},{"key":"CategorySoloMode","value":"0"},{"key":"ChangeEnterBehavior","value":true},{"key":"ChangeMemoEnterBehavior","value":false},{"key":"CheckCreditBalances","value":true},{"key":"CheckNumbers","value":false},{"key":"ClearSelection","value":false},{"key":"CollapseInspector","value":false},{"key":"CollapseSideMenu","value":true},{"key":"ColourBlindMode","value":false},{"key":"CompactIncomeVsExpense","value":true},{"key":"ConfirmEditTransactionCancellation","value":true},{"key":"ConfirmKeyboardCancelationOfTransactionChanges","value":false},{"key":"CreditCardEmoji","value":true},{"key":"CtrlEnterCleared","value":false},{"key":"CurrentMonthIndicator","value":true},{"key":"CustomFlagNames","value":false},{"key":"CustomizeColourScheme","value":true},{"key":"DateOfMoney","value":true},{"key":"DaysOfBuffering","value":"12"},{"key":"DaysOfBufferingDate","value":true},{"key":"DaysOfBufferingExcludeCreditCards","value":false},{"key":"DaysOfBufferingHistoryLookup","value":"12"},{"key":"DefaultCCToCleared","value":false},{"key":"DeselectTransactionsOnSave","value":false},{"key":"DisableToolkit","value":false},{"key":"DisplayMonthlyGoalsOverview","value":false},{"key":"DisplayTargetGoalAmount","value":"0"},{"key":"DisplayTotalMonthlyGoals","value":true},{"key":"DisplayTotalOverspent","value":false},{"key":"DisplayUpcomingAmount","value":true},{"key":"EasyTransactionApproval","value":true},{"key":"EditAccountButton","value":"0"},{"key":"EnlargeCategoriesDropdown","value":true},{"key":"EnterToMove","value":true},{"key":"FilterCategories","value":true},{"key":"GoalIndicator","value":true},{"key":"GoalWarningColor","value":true},{"key":"GoogleFontsSelector","value":"0"},{"key":"HideAccountBalancesType","value":"0"},{"key":"HideAgeOfMoney","value":false},{"key":"HideClosedAccounts","value":true},{"key":"HideDebtRatio","value":false},{"key":"HideHelp","value":false},{"key":"HideReferralBanner","value":false},{"key":"HideTotalAvailable","value":false},{"key":"HighlightNegatives","value":true},{"key":"HoveredBudgetRows","value":false},{"key":"ImportNotification","value":"2"},{"key":"IncomeFromLastMonth","value":"3"},{"key":"IncomeVsExpenseHoverHighlight","value":true},{"key":"LargerClickableIcons","value":false},{"key":"LastReconciledDate","value":"disabled"},{"key":"LinkToInflows","value":true},{"key":"LiveOnLastMonthsIncome","value":"3"},{"key":"MasterCategoryRowColor","value":true},{"key":"MasterCategoryRowColorSelect","value":"#d1d1d6"},{"key":"MasterCategoryRowDarkColorSelect","value":"#636366"},{"key":"MemoAsMarkdown","value":false},{"key":"MonthlyNotesPopupWidth","value":"0"},{"key":"NavDisplayDensity","value":"2"},{"key":"NotesAsMarkdown","value":false},{"key":"POSStyleCurrencyEntryMode","value":false},{"key":"Pacing","value":"0"},{"key":"PrintingImprovements","value":true},{"key":"PrivacyMode","value":"2"},{"key":"QuickBudgetWarning","value":true},{"key":"ReconcileAssistant","value":true},{"key":"ReconcileBalance","value":true},{"key":"ReconcileConfetti","value":true},{"key":"ReconciledTextColor","value":"1"},{"key":"RemovePositiveHighlight","value":true},{"key":"RemoveZeroCategories","value":true},{"key":"ResizeInspector","value":true},{"key":"ResizeSidebar","value":false},{"key":"RightClickToEdit","value":true},{"key":"RowHeight","value":"2"},{"key":"RowsHeight","value":"2"},{"key":"SavingsRatio","value":"0.10"},{"key":"ScrollableEditMenu","value":false},{"key":"SeamlessBudgetHeader","value":false},{"key":"SetMultipleFlags","value":false},{"key":"ShowAvailableAfterSavings","value":false},{"key":"ShowCategoryBalance","value":true},{"key":"SpareChange","value":false},{"key":"SplitTransactionAutoAdjust","value":false},{"key":"SplitTransactionAutoFillPayee","value":false},{"key":"SplitTransactionTabExpand","value":false},{"key":"SquareNegativeMode","value":false},{"key":"StealingFromFuture","value":true},{"key":"StripedBudgetRows","value":true},{"key":"SubtractUpcomingFromAvailable","value":false},{"key":"SwapClearedFlagged","value":false},{"key":"TargetBalanceWarning","value":true},{"key":"ToBeBudgetedWarning","value":true},{"key":"ToggleAccountColumns","value":true},{"key":"ToggleMasterCategories","value":false},{"key":"ToggleSplits","value":true},{"key":"ToggleTransactionFilters","value":"1"},{"key":"ToolkitReports","value":true},{"key":"UnclearedAccountHighlight","value":false},{"key":"ViewZeroAsEmpty","value":true},{"key":"l10n","value":"0"},{"key":"options.dark-mode","value":true}]

portsauthority commented 2 years ago

@michaelcmelton I can confirm I still have this issue as well -- I can produce it by creating a test mortgage, creating payment history (with escrow included), and then viewing net worth in YNAB reports vs. Toolkit reports. See attached screenshots for reference and differing NW amounts. The YNAB report reads the actual loan balance, while it appears the toolkit report is calculating based off of payments without considering interest.

Screen Shot 2022-06-27 at 12 25 29 PM Screen Shot 2022-06-27 at 12 25 06 PM Screen Shot 2022-06-27 at 12 25 45 PM

Steph-74 commented 2 years ago

I have the same issue with Toolkit for YNAB v3.3.4. Comparing the Toolkit's Net Worth Report output against the YNAB standard, the Toolkit report's net worth is to high. The "intrest paid so far" from all my loans adds up exactly to the delta of the two net worth reports ...

masanbol commented 1 year ago

I am also having this issue with the latest version - agreed that it does have something to do with how mortgage debt/interest is calculated and displayed by YNAB. Interestingly it seems like reconciling my mortgage account changes what Toolkit displays - is unreconciled debt or balance not included in the the Toolkit net worth calculation?

argoreham commented 1 year ago

Is this effect happening any longer? My Toolkit Net Worth report now matches the built-in one, it was previously off by the interest payments as documented above. I think this must be a recent change - interest transactions on loan accounts recently seem to have been added to the public API, too.

Also, I think #2882 and #2900 are dupes of this one.

tkemp6 commented 1 year ago

I'm still about $6K off

On Sun, Apr 9, 2023 at 10:09 AM Tyler Kemp @.***> wrote:

On Sun, Apr 9, 2023 at 4:02 AM argoreham @.***> wrote:

Is this effect happening any longer? My Toolkit Net Worth report now matches the built-in one, it was previously off by the interest payments as documented above. I think this must be a recent change - interest transactions on loan accounts recently seem to have been added to the public API, too.

Also, I think #2882 https://github.com/toolkit-for-ynab/toolkit-for-ynab/issues/2882 and

2900 https://github.com/toolkit-for-ynab/toolkit-for-ynab/issues/2900

are dupes of this one.

— Reply to this email directly, view it on GitHub https://github.com/toolkit-for-ynab/toolkit-for-ynab/issues/2699#issuecomment-1501070484, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHSC5TFYPAUNTJNGK4TFV2TXAJUJFANCNFSM5RAQVDTQ . You are receiving this because you were mentioned.Message ID: @.***>

OlegWock commented 9 months ago

Hello! We're running effort to cleanup issues a bit so we'll be able to actually keep track of them. This bug report seem to be quite old, so I'm going to close it. But if issue is still present, please let me know and I'll reopen it.

saxtonjoshua1 commented 9 months ago

I believe this has been a long standing bug because the net worth does not account for loan accounts accurately for interest and I don't think it has been fixed with a pull request can we double check?

Sent from my T-Mobile 5G Device Get Outlook for Androidhttps://aka.ms/AAb9ysg


From: Oleh @.> Sent: Friday, March 1, 2024 3:58:02 PM To: toolkit-for-ynab/toolkit-for-ynab @.> Cc: Joshua Saxton @.>; Comment @.> Subject: Re: [toolkit-for-ynab/toolkit-for-ynab] Net Worth Chart Doesn't Total Right (Issue #2699)

Hello! We're running effort to cleanup issues a bit so we'll be able to actually keep track of them. This bug report seem to be quite old, so I'm going to close it. But if issue is still present, please let me know and I'll reopen it.

— Reply to this email directly, view it on GitHubhttps://github.com/toolkit-for-ynab/toolkit-for-ynab/issues/2699#issuecomment-1973908938, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABCFY6IJVQ44RHT5WPB5VB3YWDTVVAVCNFSM5RAQVDT2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJXGM4TAOBZGM4A. You are receiving this because you commented.Message ID: @.***>

OlegWock commented 9 months ago

There is no PR attached to this issue, so unless it was accidentally fixed by other PR it could still be an issue. I however didn't used loan accounts in YNAB and not really sure how they work, so if someone from had this issue could check if it's still there that would be awesome

saxtonjoshua1 commented 9 months ago

@OlegWock This is duplicate of #2900 , #2882 and I think 2900 hundred had a suggestion of how to fix the issue, but I don't think it's really been fixed yet. I am not aware of a pull request to fix it and I have noticed my net worth reports are still off.

Could we consolidate these issues as part of your cleanup? Thanks! If we can consolidate the issues, I will see if it's resolved or been fixed this weekend.

saxtonjoshua1 commented 9 months ago

Yeah 2900 is close to solving the problem, so you can keep this closed as duplicate of that. I doubt its been fixed, the last comment was in November.

OlegWock commented 9 months ago

Perfect, thanks for checking