tooll3 / t3

Tooll 3 is an open source software to create realtime motion graphics.
MIT License
3.48k stars 193 forks source link

Feature Request - Dev Build Header Populates Commit SHA #351

Open sense-amr opened 10 months ago

sense-amr commented 10 months ago

It would make it great for tracking bugs and development purposes if the Header of Dev Build could populate the used commit SHA ..

ylmrx commented 9 months ago

this is gonna be difficult to achieve until we bite the CI bullet :)

It shouldn't be too complicated with the code part, but it make much more sense to then have the whole package pushed embedding the change in code (otherwise we'll have to deal w/ a LOT of maintainance commits).

i drafted the "pop the action" + replace part (reference the commit_id there is as trivial as $env:GITHUB_COMMIT_SHA) here : https://github.com/ylmrx/t3/blob/dev/.github/workflows/dotnet-desktop.yml

executed as: https://github.com/ylmrx/t3/actions/runs/7863244025/job/21453637444

(ps: as you most likely expect, and thus minimal at our scales, this might require a few bucks/month toward github too (worth it imho, but i have no idea about their pricing))

pixtur commented 9 months ago

I am not really sure. I think there are probably prebuild-scripts for MS-build to achieve this.

ylmrx commented 9 months ago

The example i'm showing in comment above is 95% the default prebuilt-script from github-actions.

also cf. https://github.com/microsoft/github-actions-for-desktop-apps?tab=readme-ov-file#versioning (linked in yml header)

pixtur commented 6 months ago

I think the current solution of the "build-standalone" solution is going to be obsolete as soon as we switch to the main branch. We then should look in to CI/CD again.

sense-amr commented 6 months ago

Great i look forward to the next iteration of the branch .. that solves the build standalone paradigm

sense-amr commented 6 months ago

Solving this issue in the main branch going forward could easily be achieved by Adding the aft requested "About" option to the UI for the splash screen and or populate with version number in header