search

tooll3 / t3

Tooll 3 is an open source software to create realtime motion graphics.
MIT License
3.41k stars 189 forks source link

Bypassed nodes are not bypassed on load #446

Closed rstecca closed 3 months ago

rstecca commented 3 months ago

Describe the bug Nodes that are marked as bypassed still contribute to the graph when the operator is loaded.

General information:

To Reproduce

  1. Create an empty project. Don't delete the template nodes.
  2. Add a Transform node between Text and RenderTarget, set an offset (for example change Translation's Y to 0.250)
  3. Select the Transform node and mark it for bypass (SHIFT+B)
  4. Save
  5. Close T3
  6. Open T3 and load the test project.
  7. See that despite the Transform is visually marked as bypassed, it still contributes to the graph.

Expected behavior On load, bypassed nodes should be initialized so they are effectively bypassed.

Screenshots image

Additional context It doesn't seem to depend on the type of node as I tested with a few and this problem is consistent.

pixtur commented 3 months ago

Thanks for this excellent bug report. I thought this issues was fixed with f329a2871d5827eb46e08a4be0f51a9bb957bd46

I will look into this.

pixtur commented 3 months ago

I tried to reproduce this issue with the current dev branch and the issue appears to be fixed for the upcoming release.

rstecca commented 3 months ago

That's great! Looking forward to the next release!

pixtur commented 3 months ago

Here you go: https://github.com/tooll3/t3/releases/tag/v3.9.2