toolness / p5.js-widget

A reusable widget for embedding editable p5 sketches in web pages.
https://toolness.github.io/p5.js-widget/
GNU Lesser General Public License v2.1
162 stars 44 forks source link

Add documentation for using the widget with Wordpress #62

Closed kaganjd closed 8 years ago

kaganjd commented 8 years ago

Fixes #56.

kaganjd commented 8 years ago

I wasn't really able to check this—my formatting looked really weird in the browser, even though I deleted and re-cloned the repo—so it's worth checking manually. I'm happy to make any edits.

toolness commented 8 years ago

This looks great, thanks! I've made a few minor changes and filed them as a PR to this PR:

https://github.com/kaganjd/p5.js-widget/pull/1

Um, I guess I should have just made comments on this PR instead, but too late now. If you think they look OK feel free to merge that PR, and then I'll merge this one!

toolness commented 8 years ago

woooot thanks!!

kaganjd commented 8 years ago

@toolness Gah, I think I did some weird Git stuff before you merged and the changes didn't get in. On my master, I did git cherry-pick <your commit> and pushed that up. Should I open another PR against your master? Or you wanna cherry-pick on your end? Sorry about this :-/

toolness commented 8 years ago

No worries, I ended up cherry-picking on my end :)