search

toolness / p5.js-widget

A reusable widget for embedding editable p5 sketches in web pages.
https://toolness.github.io/p5.js-widget/
GNU Lesser General Public License v2.1
162 stars 44 forks source link

Add user control of LoopChecker#maxLoopLength limit #69

Closed DexterShepherd closed 6 years ago

DexterShepherd commented 7 years ago

Hey All,

Thanks for the great widget! I recently needed to load a fairly large .obj into a sketch during preload() and ran up against the LoopChecker killing my sketch before I was able to load the resource. Forking the repo and commenting out the error throwing line in LoopChecker fixed the issue.

Would you be open to a PR adding data-loopcheck-enable and/or data-loopcheck-length as user configurable parameters on the parent <script> element?

Thanks again,

Dexter

toolness commented 7 years ago

Oh that's a great idea! Sure, I'd be happy to accept such a PR, thanks for offering.