toolness / pancakes

An interactive fiction about making pancakes on a Saturday morning.
http://toolness.github.io/pancakes/
0 stars 0 forks source link

Measured Liquid doesn't compile on Inform 7 release 6M62 #1

Open toolness opened 8 years ago

toolness commented 8 years ago

From my intfiction.org post:

Hello! Thanks for writing this extension. It works great in release 6L38, which is currently the second-to-latest release, but I noticed that it doesn't compile on what is currently the latest release, 6M62 (which seems to be available only on OS X, for some reason). It seems to fail with the following problem:

Problem. You wrote 'let L be the value produced by the liquid-mixing rules for the amount poured' , but although 'value' is the name of a kind, it isn't a definite kind and is instead a general description which might apply to many different kinds. (For example, 'let R be a relation' is vague because it doesn't make clear what R will relate - 'let R be a relation of numbers' would be fine.)
I was trying to match one of these phrases:

1. (value - name of kind) produced by (liquid-mixing rules - values based rule producing values) for (amount poured - value)
2. (value - name of kind) produced by (liquid-mixing rules for the amount poured - rule producing values)
3. (value - name of kind) produced by (liquid-mixing rules for the amount poured - nothing based rule producing values)
I recognised:

value = a description of values
liquid-mixing rules = a volumes based rulebook producing liquids
amount poured = a non-temporary variable, holding a volume
But I didn't recognise 'liquid-mixing rules for the amount poured'.

The following problem was also output:

Problem. In the sentence 'now the resulting liquid is L' , I was expecting to read a condition, but instead found some text that I couldn't understand - 'the resulting liquid is L'.
toolness commented 8 years ago

This problem seems to be fixed by changing the word "value" to "liquid". Here's a diff against version 6 of the extension:

--- Measured Liquid.i7x 2016-01-01 09:08:21.000000000 -0500
+++ FIXED_Measured Liquid.i7x   2016-01-01 09:08:02.000000000 -0500
@@ -681,7 +681,7 @@
        make no decision;
    if the liquid poured is not the liquid of the second noun: 
        if amount poured is greater than null volume and the second noun is non-empty:
-           let L be the value produced by the liquid-mixing rules for the amount poured;
+           let L be the liquid produced by the liquid-mixing rules for the amount poured;
            now the resulting liquid is L.

 Section 3 - Liquid-mixing Rulebook

The patch appears to make Measured Liquid work on both release 6L38 and 6M62, though I haven't tried it on earlier versions of Inform 7.