Open peterwald opened 9 years ago
Fix is in to ignore testdata. That should help with this issue.
@neurogeek I would rather say that testdata files should just be copied over as is w/o attempting to parse. This is especially true as we move to the use of vendor/
and some of the discussions I've seen crop up around testing vendored code.
Cool. I'll revisit the solution then.
When running
godep save
on a project that includes a reference to golang.org/x/tools/go/loader, godep does not copy the files in the go/loader package.The following error is returned from the command line.
This appears to be because there is a test file in that package that is deliberately missing the package statement, and godep fails to parse it. go/loader/testdata/badpkgdecl.go
Rather than failing to copy the entire package, godep should skip parsing this file on error (i.e. not discovering any imports) and move along, successfully vendoring the package.
Reference issue sourcegraph/srclib-go#30.