search

tools / godep

dependency tool for go
http://godoc.org/github.com/tools/godep
BSD 3-Clause "New" or "Revised" License
5.54k stars 454 forks source link

github.com/libopenstorage/openstorage usage #368

Closed freeformz closed 8 years ago

freeformz commented 8 years ago

Moving this discussion from #358. /cc @peter-edge

bufdev commented 8 years ago

The things you listed in #358 do not affect the bug. I branched openstorage to use godep in the manner that is suggested, the bug still exists: https://github.com/libopenstorage/openstorage/tree/godep_normal - I think the original bug should be opened, this branch can be worked off of.

freeformz commented 8 years ago

Can you commit the Godeps/Godeps.json file that your are using so that I can investigate?

bufdev commented 8 years ago

That branch actually can't even get a Godep.json file into it because godep is broken and won't get all the dependencies in - imagine you have a completely fresh libopenstorage, no vendoring, that you want to now use godep with. As of v33, you can't do that, because it misses a ton of dependencies.

freeformz commented 8 years ago

You would have already created a Godeps/Godeps.json file when you originally saved your vendor/ directory. You would then godep restore things into your $GOPATH. FWIW: I realize that this usage with vendor/ is less than optimal, but I can't change it too much w/o breaking the non vendor/ way ATM.

bufdev commented 8 years ago

I can try to get one in tomorrow using v32, but the bug would be the same if this was a first time usage of godep. There's a couple recent things that may cause other errors, so I will let you know, but this bug does not require previous usage of godep.

On Thursday, December 17, 2015, Edward Muller notifications@github.com wrote:

Can you commit the Godeps/Godeps.json file that your are using so that I can investigate?

— Reply to this email directly or view it on GitHub https://github.com/tools/godep/issues/368#issuecomment-165290631.

bufdev commented 8 years ago

Tl;dr: the existence of a past vendor and/or godep directory has no effect on the repeatability of this bug

On Thursday, December 17, 2015, Peter Edge peter.edge@gmail.com wrote:

I can try to get one in tomorrow using v32, but the bug would be the same if this was a first time usage of godep. There's a couple recent things that may cause other errors, so I will let you know, but this bug does not require previous usage of godep.

On Thursday, December 17, 2015, Edward Muller <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

Can you commit the Godeps/Godeps.json file that your are using so that I can investigate?

— Reply to this email directly or view it on GitHub https://github.com/tools/godep/issues/368#issuecomment-165290631.

freeformz commented 8 years ago

let me see if I can repro after manually installing all the deps.

freeformz commented 8 years ago

Heh. I see there is a makefile target for that.

bufdev commented 8 years ago

There's an issue I found (unrelated to bug but will Affect you) so let me fix it first so I don't waste any of your time :)

On Thursday, December 17, 2015, Edward Muller notifications@github.com wrote:

let me see if I can repro after manually installing all the deps.

— Reply to this email directly or view it on GitHub https://github.com/tools/godep/issues/368#issuecomment-165294280.

freeformz commented 8 years ago 
$ mkdir ~/go2
$ export GOPATH=~/go2
$ go get -d github.com/libopenstorage/openstorage
package github.com/libopenstorage/openstorage: no buildable Go source files in /Users/emuller/go2/src/github.com/libopenstorage/openstorage
$ cd ~/go2/src/github.com/libopenstorage/openstorage
$ make update-test-deps
$ make update-test-deps
GO15VENDOREXPERIMENT=0 go get -d -v -t -u -f github.com/libopenstorage/openstorage/api github.com/libopenstorage/openstorage/api/client github.com/libopenstorage/openstorage/api/server github.com/libopenstorage/openstorage/cli github.com/libopenstorage/openstorage/cluster github.com/libopenstorage/openstorage/cmd/osd github.com/libopenstorage/openstorage/config github.com/libopenstorage/openstorage/graph github.com/libopenstorage/openstorage/graph/drivers github.com/libopenstorage/openstorage/graph/drivers/layer0 github.com/libopenstorage/openstorage/graph/drivers/proxy github.com/libopenstorage/openstorage/pkg/chaos github.com/libopenstorage/openstorage/pkg/device github.com/libopenstorage/openstorage/pkg/mount github.com/libopenstorage/openstorage/pkg/seed github.com/libopenstorage/openstorage/pkg/stats github.com/libopenstorage/openstorage/volume github.com/libopenstorage/openstorage/volume/drivers github.com/libopenstorage/openstorage/volume/drivers/aws github.com/libopenstorage/openstorage/volume/drivers/btrfs github.com/libopenstorage/openstorage/volume/drivers/buse github.com/libopenstorage/openstorage/volume/drivers/fuse github.com/libopenstorage/openstorage/volume/drivers/nfs github.com/libopenstorage/openstorage/volume/drivers/pwx github.com/libopenstorage/openstorage/volume/drivers/test github.com/libopenstorage/openstorage/volume/drivers/vfs
github.com/libopenstorage/openstorage (download)
github.com/fsouza/go-dockerclient (download)
github.com/portworx/systemutils (download)
github.com/Sirupsen/logrus (download)
github.com/libopenstorage/gossip (download)
github.com/portworx/kvdb (download)
Fetching https://gopkg.in/yaml.v2?go-get=1
Parsing meta tags from https://gopkg.in/yaml.v2?go-get=1 (status code 200)
get "gopkg.in/yaml.v2": found meta tag main.metaImport{Prefix:"gopkg.in/yaml.v2", VCS:"git", RepoRoot:"https://gopkg.in/yaml.v2"} at https://gopkg.in/yaml.v2?go-get=1
gopkg.in/yaml.v2 (download)
github.com/docker/docker (download)
Fetching https://golang.org/x/net/context?go-get=1
Parsing meta tags from https://golang.org/x/net/context?go-get=1 (status code 200)
get "golang.org/x/net/context": found meta tag main.metaImport{Prefix:"golang.org/x/net", VCS:"git", RepoRoot:"https://go.googlesource.com/net"} at https://golang.org/x/net/context?go-get=1
get "golang.org/x/net/context": verifying non-authoritative meta tag
Fetching https://golang.org/x/net?go-get=1
Parsing meta tags from https://golang.org/x/net?go-get=1 (status code 200)
golang.org/x/net (download)
github.com/gorilla/mux (download)
github.com/gorilla/context (download)
github.com/pborman/uuid (download)
github.com/stretchr/testify (download)
github.com/davecgh/go-spew (download)
github.com/pmezard/go-difflib (download)
github.com/codegangsta/cli (download)
package github.com/libopenstorage/openstorage/graph/drivers/unionfs: no buildable Go source files in /Users/emuller/go2/src/github.com/libopenstorage/openstorage/graph/drivers/unionfs
github.com/aws/aws-sdk-go (download)
github.com/go-ini/ini (download)
github.com/jmespath/go-jmespath (download)
github.com/hashicorp/consul (download)
github.com/hashicorp/go-cleanhttp (download)
github.com/hashicorp/serf (download)
github.com/coreos/go-etcd (download)
github.com/ugorji/go (download)
Fetching https://bazil.org/fuse?go-get=1
Parsing meta tags from https://bazil.org/fuse?go-get=1 (status code 200)
get "bazil.org/fuse": found meta tag main.metaImport{Prefix:"bazil.org/fuse", VCS:"git", RepoRoot:"https://github.com/bazil/fuse"} at https://bazil.org/fuse?go-get=1
bazil.org/fuse (download)
Fetching https://bazil.org/fuse/fs?go-get=1
Parsing meta tags from https://bazil.org/fuse/fs?go-get=1 (status code 200)
get "bazil.org/fuse/fs": found meta tag main.metaImport{Prefix:"bazil.org/fuse", VCS:"git", RepoRoot:"https://github.com/bazil/fuse"} at https://bazil.org/fuse/fs?go-get=1
get "bazil.org/fuse/fs": verifying non-authoritative meta tag
Fetching https://bazil.org/fuse?go-get=1
Parsing meta tags from https://bazil.org/fuse?go-get=1 (status code 200)
make: *** [update-test-deps] Error 1
$ godep save github.com/libopenstorage/openstorage/api github.com/libopenstorage/openstorage/api/client github.com/libopenstorage/openstorage/api/server github.com/libopenstorage/openstorage/cli github.com/libopenstorage/openstorage/cluster github.com/libopenstorage/openstorage/cmd/osd github.com/libopenstorage/openstorage/config github.com/libopenstorage/openstorage/graph github.com/libopenstorage/openstorage/graph/drivers github.com/libopenstorage/openstorage/graph/drivers/layer0 github.com/libopenstorage/openstorage/graph/drivers/proxy github.com/libopenstorage/openstorage/pkg/chaos github.com/libopenstorage/openstorage/pkg/device github.com/libopenstorage/openstorage/pkg/mount github.com/libopenstorage/openstorage/pkg/seed github.com/libopenstorage/openstorage/pkg/stats github.com/libopenstorage/openstorage/volume github.com/libopenstorage/openstorage/volume/drivers github.com/libopenstorage/openstorage/volume/drivers/aws github.com/libopenstorage/openstorage/volume/drivers/btrfs github.com/libopenstorage/openstorage/volume/drivers/buse github.com/libopenstorage/openstorage/volume/drivers/fuse github.com/libopenstorage/openstorage/volume/drivers/nfs github.com/libopenstorage/openstorage/volume/drivers/pwx github.com/libopenstorage/openstorage/volume/drivers/test github.com/libopenstorage/openstorage/volume/drivers/vfs
godep: cannot find package "golang.org/x/sys/unix" in any of:
    /usr/local/go/src/golang.org/x/sys/unix (from $GOROOT)
    /Users/emuller/go2/src/golang.org/x/sys/unix (from $GOPATH)
$ go get -d golang.org/x/sys/unix
$ godep save github.com/libopenstorage/openstorage/api github.com/libopenstorage/openstorage/api/client github.com/libopenstorage/openstorage/api/server github.com/libopenstorage/openstorage/cli github.com/libopenstorage/openstorage/cluster github.com/libopenstorage/openstorage/cmd/osd github.com/libopenstorage/openstorage/config github.com/libopenstorage/openstorage/graph github.com/libopenstorage/openstorage/graph/drivers github.com/libopenstorage/openstorage/graph/drivers/layer0 github.com/libopenstorage/openstorage/graph/drivers/proxy github.com/libopenstorage/openstorage/pkg/chaos github.com/libopenstorage/openstorage/pkg/device github.com/libopenstorage/openstorage/pkg/mount github.com/libopenstorage/openstorage/pkg/seed github.com/libopenstorage/openstorage/pkg/stats github.com/libopenstorage/openstorage/volume github.com/libopenstorage/openstorage/volume/drivers github.com/libopenstorage/openstorage/volume/drivers/aws github.com/libopenstorage/openstorage/volume/drivers/btrfs github.com/libopenstorage/openstorage/volume/drivers/buse github.com/libopenstorage/openstorage/volume/drivers/fuse github.com/libopenstorage/openstorage/volume/drivers/nfs github.com/libopenstorage/openstorage/volume/drivers/pwx github.com/libopenstorage/openstorage/volume/drivers/test github.com/libopenstorage/openstorage/volume/drivers/vfs
$ find Godeps
Godeps
Godeps/Godeps.json
Godeps/Readme
$ cat Godeps/Godeps.json
{
    "ImportPath": "github.com/libopenstorage/openstorage",
    "GoVersion": "go1.5",
    "Packages": [
        "github.com/libopenstorage/openstorage/api",
        "github.com/libopenstorage/openstorage/api/client",
        "github.com/libopenstorage/openstorage/api/server",
        "github.com/libopenstorage/openstorage/cli",
        "github.com/libopenstorage/openstorage/cluster",
        "github.com/libopenstorage/openstorage/cmd/osd",
        "github.com/libopenstorage/openstorage/config",
        "github.com/libopenstorage/openstorage/graph",
        "github.com/libopenstorage/openstorage/graph/drivers",
        "github.com/libopenstorage/openstorage/graph/drivers/layer0",
        "github.com/libopenstorage/openstorage/graph/drivers/proxy",
        "github.com/libopenstorage/openstorage/pkg/chaos",
        "github.com/libopenstorage/openstorage/pkg/device",
        "github.com/libopenstorage/openstorage/pkg/mount",
        "github.com/libopenstorage/openstorage/pkg/seed",
        "github.com/libopenstorage/openstorage/pkg/stats",
        "github.com/libopenstorage/openstorage/volume",
        "github.com/libopenstorage/openstorage/volume/drivers",
        "github.com/libopenstorage/openstorage/volume/drivers/aws",
        "github.com/libopenstorage/openstorage/volume/drivers/btrfs",
        "github.com/libopenstorage/openstorage/volume/drivers/buse",
        "github.com/libopenstorage/openstorage/volume/drivers/fuse",
        "github.com/libopenstorage/openstorage/volume/drivers/nfs",
        "github.com/libopenstorage/openstorage/volume/drivers/pwx",
        "github.com/libopenstorage/openstorage/volume/drivers/test",
        "github.com/libopenstorage/openstorage/volume/drivers/vfs"
    ],
    "Deps": [
        {
            "ImportPath": "bazil.org/fuse",
            "Rev": "a8bc3b86317dc95ed28fdefcebc1dbce8baa88e9"
        },
        {
            "ImportPath": "github.com/Sirupsen/logrus",
            "Comment": "v0.8.7-53-g446d1c1",
            "Rev": "446d1c146faa8ed3f4218f056fcd165f6bcfda81"
        },
        {
            "ImportPath": "github.com/aws/aws-sdk-go/aws",
            "Comment": "v1.0.5",
            "Rev": "9e7816464bb6044ae17fff44ce59387d2658e2cb"
        },
        {
            "ImportPath": "github.com/aws/aws-sdk-go/service/ec2",
            "Comment": "v1.0.5",
            "Rev": "9e7816464bb6044ae17fff44ce59387d2658e2cb"
        },
        {
            "ImportPath": "github.com/aws/aws-sdk-go/service/opsworks",
            "Comment": "v1.0.5",
            "Rev": "9e7816464bb6044ae17fff44ce59387d2658e2cb"
        },
        {
            "ImportPath": "github.com/codegangsta/cli",
            "Comment": "1.2.0-183-gb5232bb",
            "Rev": "b5232bb2934f606f9f27a1305f1eea224e8e8b88"
        },
        {
            "ImportPath": "github.com/davecgh/go-spew/spew",
            "Rev": "5215b55f46b2b919f50a1df0eaa5886afe4e3b3d"
        },
        {
            "ImportPath": "github.com/docker/docker/daemon/graphdriver",
            "Comment": "v1.4.1-8593-g905f333",
            "Rev": "905f3336b2715b3960b5ff4f860db387797d9adf"
        },
        {
            "ImportPath": "github.com/docker/docker/pkg/archive",
            "Comment": "v1.4.1-8593-g905f333",
            "Rev": "905f3336b2715b3960b5ff4f860db387797d9adf"
        },
        {
            "ImportPath": "github.com/docker/docker/pkg/idtools",
            "Comment": "v1.4.1-8593-g905f333",
            "Rev": "905f3336b2715b3960b5ff4f860db387797d9adf"
        },
        {
            "ImportPath": "github.com/docker/docker/pkg/mount",
            "Comment": "v1.4.1-8593-g905f333",
            "Rev": "905f3336b2715b3960b5ff4f860db387797d9adf"
        },
        {
            "ImportPath": "github.com/docker/docker/pkg/parsers",
            "Comment": "v1.4.1-8593-g905f333",
            "Rev": "905f3336b2715b3960b5ff4f860db387797d9adf"
        },
        {
            "ImportPath": "github.com/docker/docker/pkg/reexec",
            "Comment": "v1.4.1-8593-g905f333",
            "Rev": "905f3336b2715b3960b5ff4f860db387797d9adf"
        },
        {
            "ImportPath": "github.com/fsouza/go-dockerclient",
            "Rev": "54afc1babbc57f075f958f84904251332bd8fd73"
        },
        {
            "ImportPath": "github.com/go-ini/ini",
            "Comment": "v1.8.5-1-g467243b",
            "Rev": "467243bad6cb295e0fe72366da5ba85b069874cb"
        },
        {
            "ImportPath": "github.com/gorilla/mux",
            "Rev": "9c068cf16d982f8bd444b8c352acbeec34c4fe5b"
        },
        {
            "ImportPath": "github.com/libopenstorage/gossip",
            "Rev": "8ef1994e46b7dc4fd407994c735044c0fd39e9de"
        },
        {
            "ImportPath": "github.com/pborman/uuid",
            "Rev": "dee7705ef7b324f27ceb85a121c61f2c2e8ce988"
        },
        {
            "ImportPath": "github.com/pmezard/go-difflib/difflib",
            "Rev": "e8554b8641db39598be7f6342874b958f12ae1d4"
        },
        {
            "ImportPath": "github.com/portworx/kvdb",
            "Rev": "496e86135d7e307722af6649ec640fd385a385c5"
        },
        {
            "ImportPath": "github.com/portworx/systemutils",
            "Rev": "231787edf3530fee4c73695dd8c4090f4af7764e"
        },
        {
            "ImportPath": "github.com/stretchr/testify/assert",
            "Comment": "v1.0-88-ge3a8ff8",
            "Rev": "e3a8ff8ce36581f87a15341206f205b1da467059"
        },
        {
            "ImportPath": "github.com/stretchr/testify/require",
            "Comment": "v1.0-88-ge3a8ff8",
            "Rev": "e3a8ff8ce36581f87a15341206f205b1da467059"
        },
        {
            "ImportPath": "golang.org/x/sys/unix",
            "Rev": "833a04a10549a95dc34458c195cbad61bbb6cb4d"
        },
        {
            "ImportPath": "gopkg.in/yaml.v2",
            "Rev": "f7716cbe52baa25d2e9b0d0da546fcf909fc16b4"
        }
    ]
}
$ git status
On branch master
Your branch is up-to-date with 'origin/master'.
Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

    modified:   vendor/bazil.org/fuse/fuse.go
    modified:   vendor/bazil.org/fuse/fuse_kernel.go
    modified:   vendor/bazil.org/fuse/mount_darwin.go
    modified:   vendor/bazil.org/fuse/options.go
    modified:   vendor/github.com/Sirupsen/logrus/README.md
    modified:   vendor/github.com/Sirupsen/logrus/hooks/syslog/syslog.go
    modified:   vendor/github.com/Sirupsen/logrus/logger.go
    modified:   vendor/github.com/Sirupsen/logrus/terminal_notwindows.go
    modified:   vendor/github.com/Sirupsen/logrus/terminal_windows.go
    modified:   vendor/github.com/aws/aws-sdk-go/aws/awsutil/copy.go
    modified:   vendor/github.com/aws/aws-sdk-go/aws/awsutil/path_value.go
    modified:   vendor/github.com/aws/aws-sdk-go/aws/config.go
    modified:   vendor/github.com/aws/aws-sdk-go/aws/corehandlers/handlers.go
    modified:   vendor/github.com/aws/aws-sdk-go/aws/corehandlers/param_validator.go
    modified:   vendor/github.com/aws/aws-sdk-go/aws/credentials/chain_provider.go
    modified:   vendor/github.com/aws/aws-sdk-go/aws/credentials/credentials.go
    modified:   vendor/github.com/aws/aws-sdk-go/aws/credentials/ec2rolecreds/ec2_role_provider.go
    modified:   vendor/github.com/aws/aws-sdk-go/aws/credentials/example.ini
    modified:   vendor/github.com/aws/aws-sdk-go/aws/credentials/shared_credentials_provider.go
    modified:   vendor/github.com/aws/aws-sdk-go/aws/credentials/stscreds/assume_role_provider.go
    modified:   vendor/github.com/aws/aws-sdk-go/aws/defaults/defaults.go
    modified:   vendor/github.com/aws/aws-sdk-go/aws/ec2metadata/api.go
    modified:   vendor/github.com/aws/aws-sdk-go/aws/ec2metadata/service.go
    modified:   vendor/github.com/aws/aws-sdk-go/aws/errors.go
    modified:   vendor/github.com/aws/aws-sdk-go/aws/request/handlers.go
    modified:   vendor/github.com/aws/aws-sdk-go/aws/request/request.go
    modified:   vendor/github.com/aws/aws-sdk-go/aws/request/retryer.go
    deleted:    vendor/github.com/aws/aws-sdk-go/aws/service/default_retryer.go
    deleted:    vendor/github.com/aws/aws-sdk-go/aws/service/service.go
    deleted:    vendor/github.com/aws/aws-sdk-go/aws/service/serviceinfo/service_info.go
    modified:   vendor/github.com/aws/aws-sdk-go/aws/types.go
    modified:   vendor/github.com/aws/aws-sdk-go/aws/version.go
    modified:   vendor/github.com/aws/aws-sdk-go/service/ec2/api.go
    modified:   vendor/github.com/aws/aws-sdk-go/service/ec2/customizations.go
    modified:   vendor/github.com/aws/aws-sdk-go/service/ec2/ec2iface/interface.go
    modified:   vendor/github.com/aws/aws-sdk-go/service/ec2/service.go
    modified:   vendor/github.com/aws/aws-sdk-go/service/opsworks/api.go
    modified:   vendor/github.com/aws/aws-sdk-go/service/opsworks/opsworksiface/interface.go
    modified:   vendor/github.com/aws/aws-sdk-go/service/opsworks/service.go
    modified:   vendor/github.com/codegangsta/cli/.travis.yml
    modified:   vendor/github.com/codegangsta/cli/README.md
    modified:   vendor/github.com/codegangsta/cli/app.go
    modified:   vendor/github.com/codegangsta/cli/command.go
    modified:   vendor/github.com/codegangsta/cli/flag.go
    modified:   vendor/github.com/docker/docker/daemon/graphdriver/aufs/aufs.go
    modified:   vendor/github.com/docker/docker/daemon/graphdriver/aufs/migrate.go
    modified:   vendor/github.com/docker/docker/daemon/graphdriver/btrfs/btrfs.go
    modified:   vendor/github.com/docker/docker/daemon/graphdriver/btrfs/version_none.go
    modified:   vendor/github.com/docker/docker/daemon/graphdriver/devmapper/deviceset.go
    modified:   vendor/github.com/docker/docker/daemon/graphdriver/devmapper/devmapper_doc.go
    modified:   vendor/github.com/docker/docker/daemon/graphdriver/devmapper/driver.go
    modified:   vendor/github.com/docker/docker/daemon/graphdriver/devmapper/mount.go
    modified:   vendor/github.com/docker/docker/daemon/graphdriver/driver.go
    modified:   vendor/github.com/docker/docker/daemon/graphdriver/fsdiff.go
    deleted:    vendor/github.com/docker/docker/daemon/graphdriver/graphtest/graphtest.go
    deleted:    vendor/github.com/docker/docker/daemon/graphdriver/imagerestorer.go
    modified:   vendor/github.com/docker/docker/daemon/graphdriver/overlay/overlay.go
    modified:   vendor/github.com/docker/docker/daemon/graphdriver/plugin.go
    modified:   vendor/github.com/docker/docker/daemon/graphdriver/proxy.go
    modified:   vendor/github.com/docker/docker/daemon/graphdriver/vfs/driver.go
    deleted:    vendor/github.com/docker/docker/daemon/graphdriver/vfs/driver_unsupported.go
    modified:   vendor/github.com/docker/docker/daemon/graphdriver/windows/windows.go
    modified:   vendor/github.com/docker/docker/daemon/graphdriver/zfs/zfs.go
    modified:   vendor/github.com/docker/docker/pkg/archive/archive.go
    modified:   vendor/github.com/docker/docker/pkg/archive/archive_unix.go
    modified:   vendor/github.com/docker/docker/pkg/archive/archive_windows.go
    modified:   vendor/github.com/docker/docker/pkg/archive/changes.go
    modified:   vendor/github.com/docker/docker/pkg/archive/copy.go
    modified:   vendor/github.com/docker/docker/pkg/archive/diff.go
    modified:   vendor/github.com/docker/docker/pkg/archive/whiteouts.go
    modified:   vendor/github.com/docker/docker/pkg/mount/flags.go
    modified:   vendor/github.com/docker/docker/pkg/mount/flags_linux.go
    deleted:    vendor/github.com/docker/docker/pkg/parsers/filters/parse.go
    modified:   vendor/github.com/docker/docker/pkg/parsers/operatingsystem/operatingsystem_linux.go
    modified:   vendor/github.com/docker/docker/pkg/parsers/parsers.go
    modified:   vendor/github.com/docker/docker/pkg/reexec/reexec.go
    modified:   vendor/github.com/fsouza/go-dockerclient/.travis.yml
    modified:   vendor/github.com/fsouza/go-dockerclient/AUTHORS
    modified:   vendor/github.com/fsouza/go-dockerclient/Makefile
    modified:   vendor/github.com/fsouza/go-dockerclient/README.markdown
    modified:   vendor/github.com/fsouza/go-dockerclient/auth.go
    modified:   vendor/github.com/fsouza/go-dockerclient/client.go
    modified:   vendor/github.com/fsouza/go-dockerclient/container.go
    modified:   vendor/github.com/fsouza/go-dockerclient/image.go
    modified:   vendor/github.com/fsouza/go-dockerclient/network.go
    modified:   vendor/github.com/fsouza/go-dockerclient/testing/server.go
    modified:   vendor/github.com/fsouza/go-dockerclient/volume.go
    modified:   vendor/github.com/gorilla/mux/.travis.yml
    modified:   vendor/github.com/pborman/uuid/sql.go
    modified:   vendor/github.com/pmezard/go-difflib/difflib/difflib.go
    modified:   vendor/github.com/portworx/kvdb/etcd/kv_etcd.go
    modified:   vendor/github.com/portworx/systemutils/system.go
    modified:   vendor/github.com/stretchr/testify/assert/assertions.go
    modified:   vendor/github.com/stretchr/testify/assert/forward_assertions.go
    modified:   vendor/github.com/stretchr/testify/require/forward_requirements.go
    modified:   vendor/github.com/stretchr/testify/require/requirements.go
    modified:   vendor/gopkg.in/yaml.v2/readerc.go

Untracked files:
  (use "git add <file>..." to include in what will be committed)

    Godeps/
    vendor/github.com/Sirupsen/logrus/terminal_solaris.go
    vendor/github.com/aws/aws-sdk-go/LICENSE.txt
    vendor/github.com/aws/aws-sdk-go/NOTICE.txt
    vendor/github.com/aws/aws-sdk-go/aws/awsutil/equal.go
    vendor/github.com/aws/aws-sdk-go/aws/awsutil/string_value.go
    vendor/github.com/aws/aws-sdk-go/aws/client/
    vendor/github.com/aws/aws-sdk-go/aws/request/request_pagination.go
    vendor/github.com/aws/aws-sdk-go/aws/session/
    vendor/github.com/aws/aws-sdk-go/service/ec2/waiters.go
    vendor/github.com/aws/aws-sdk-go/service/opsworks/waiters.go
    vendor/github.com/davecgh/go-spew/LICENSE
    vendor/github.com/docker/docker/LICENSE
    vendor/github.com/docker/docker/NOTICE
    vendor/github.com/docker/docker/contrib/
    vendor/github.com/docker/docker/daemon/graphdriver/graphtest/graphtest_unix.go
    vendor/github.com/docker/docker/daemon/graphdriver/graphtest/graphtest_windows.go
    vendor/github.com/docker/docker/pkg/symlink/
    vendor/github.com/go-ini/
    vendor/github.com/pmezard/go-difflib/LICENSE
    vendor/github.com/stretchr/testify/LICENSE
    vendor/golang.org/x/sys/

no changes added to commit (use "git add" and/or "git commit -a")
freeformz commented 8 years ago

@peter-edge above is what I would basically expect at this point.

freeformz commented 8 years ago 
$ godep version
godep v38 (darwin/amd64/go1.5.2)
bufdev commented 8 years ago

I have the problem reproduced on a much easier (and bug free) repository: https://github.com/peter-edge/go-import-server

I added the Godep directory so you can play with it :)

bufdev commented 8 years ago

Uses godep version v41:

[~/go/src/github.com/peter-edge/go-import-server]
pedge$ godep version
godep v41 (darwin/amd64/go1.5.2)
[~/go/src/github.com/peter-edge/go-import-server]
pedge$ make vendornoupdate
#go get -v github.com/tools/godep
rm -rf Godeps
rm -rf vendor
GOOS=linux GOARCH=amd64 godep save github.com/peter-edge/go-import-server github.com/peter-edge/go-import-server/cmd/import-server github.com/peter-edge/go-import-server/data github.com/peter-edge/go-import-server/testing
#rm -rf Godeps
[~/go/src/github.com/peter-edge/go-import-server]
pedge$ git status
On branch master
Your branch is up-to-date with 'origin/master'.
Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

    modified:   Godeps/Godeps.json
    modified:   Makefile
    deleted:    vendor/github.com/davecgh/go-spew/LICENSE
    deleted:    vendor/github.com/davecgh/go-spew/spew/bypass.go
    deleted:    vendor/github.com/davecgh/go-spew/spew/bypasssafe.go
    deleted:    vendor/github.com/davecgh/go-spew/spew/common.go
    deleted:    vendor/github.com/davecgh/go-spew/spew/config.go
    deleted:    vendor/github.com/davecgh/go-spew/spew/doc.go
    deleted:    vendor/github.com/davecgh/go-spew/spew/dump.go
    deleted:    vendor/github.com/davecgh/go-spew/spew/format.go
    deleted:    vendor/github.com/davecgh/go-spew/spew/spew.go
    deleted:    vendor/github.com/golang/protobuf/LICENSE
    deleted:    vendor/github.com/golang/protobuf/proto/Makefile
    deleted:    vendor/github.com/golang/protobuf/proto/clone.go
    deleted:    vendor/github.com/golang/protobuf/proto/decode.go
    deleted:    vendor/github.com/golang/protobuf/proto/encode.go
    deleted:    vendor/github.com/golang/protobuf/proto/equal.go
    deleted:    vendor/github.com/golang/protobuf/proto/extensions.go
    deleted:    vendor/github.com/golang/protobuf/proto/lib.go
    deleted:    vendor/github.com/golang/protobuf/proto/message_set.go
    deleted:    vendor/github.com/golang/protobuf/proto/pointer_reflect.go
    deleted:    vendor/github.com/golang/protobuf/proto/pointer_unsafe.go
    deleted:    vendor/github.com/golang/protobuf/proto/properties.go
    deleted:    vendor/github.com/golang/protobuf/proto/proto3_proto/proto3.pb.go
    deleted:    vendor/github.com/golang/protobuf/proto/proto3_proto/proto3.proto
    deleted:    vendor/github.com/golang/protobuf/proto/text.go
    deleted:    vendor/github.com/golang/protobuf/proto/text_parser.go
    deleted:    vendor/github.com/matttproud/golang_protobuf_extensions/LICENSE
    deleted:    vendor/github.com/matttproud/golang_protobuf_extensions/NOTICE
    deleted:    vendor/github.com/matttproud/golang_protobuf_extensions/pbutil/decode.go
    deleted:    vendor/github.com/matttproud/golang_protobuf_extensions/pbutil/doc.go
    deleted:    vendor/github.com/matttproud/golang_protobuf_extensions/pbutil/encode.go
    deleted:    vendor/github.com/mihasya/go-metrics-librato/LICENSE
    deleted:    vendor/github.com/mihasya/go-metrics-librato/README.md
    deleted:    vendor/github.com/mihasya/go-metrics-librato/client.go
    deleted:    vendor/github.com/mihasya/go-metrics-librato/librato.go
    deleted:    vendor/github.com/pmezard/go-difflib/LICENSE
    deleted:    vendor/github.com/pmezard/go-difflib/difflib/difflib.go
    deleted:    vendor/github.com/satori/go.uuid/.travis.yml
    deleted:    vendor/github.com/satori/go.uuid/LICENSE
    deleted:    vendor/github.com/satori/go.uuid/README.md
    deleted:    vendor/github.com/satori/go.uuid/uuid.go
    deleted:    vendor/github.com/stathat/go/.gitignore
    deleted:    vendor/github.com/stathat/go/LICENSE
    deleted:    vendor/github.com/stathat/go/README.md
    deleted:    vendor/github.com/stathat/go/stathat.go
    deleted:    vendor/go.pedge.io/google-protobuf/GOLANG_PROTOBUF_LICENSE
    deleted:    vendor/go.pedge.io/google-protobuf/GOOGLE_PROTOBUF_LICENSE
    deleted:    vendor/go.pedge.io/google-protobuf/LICENSE
    deleted:    vendor/go.pedge.io/google-protobuf/Makefile
    deleted:    vendor/go.pedge.io/google-protobuf/README.md
    deleted:    vendor/go.pedge.io/google-protobuf/any.pb.go
    deleted:    vendor/go.pedge.io/google-protobuf/any.proto
    deleted:    vendor/go.pedge.io/google-protobuf/api.pb.go
    deleted:    vendor/go.pedge.io/google-protobuf/api.proto
    deleted:    vendor/go.pedge.io/google-protobuf/circle.yml
    deleted:    vendor/go.pedge.io/google-protobuf/duration.pb.go
    deleted:    vendor/go.pedge.io/google-protobuf/duration.proto
    deleted:    vendor/go.pedge.io/google-protobuf/empty.pb.go
    deleted:    vendor/go.pedge.io/google-protobuf/empty.proto
    deleted:    vendor/go.pedge.io/google-protobuf/field_mask.pb.go
    deleted:    vendor/go.pedge.io/google-protobuf/field_mask.proto
    deleted:    vendor/go.pedge.io/google-protobuf/google_protobuf.go
    deleted:    vendor/go.pedge.io/google-protobuf/source_context.pb.go
    deleted:    vendor/go.pedge.io/google-protobuf/source_context.proto
    deleted:    vendor/go.pedge.io/google-protobuf/struct.pb.go
    deleted:    vendor/go.pedge.io/google-protobuf/struct.proto
    deleted:    vendor/go.pedge.io/google-protobuf/timestamp.pb.go
    deleted:    vendor/go.pedge.io/google-protobuf/timestamp.proto
    deleted:    vendor/go.pedge.io/google-protobuf/type.pb.go
    deleted:    vendor/go.pedge.io/google-protobuf/type.proto
    deleted:    vendor/go.pedge.io/google-protobuf/wrappers.pb.go
    deleted:    vendor/go.pedge.io/google-protobuf/wrappers.proto
    deleted:    vendor/go.pedge.io/pkg/log/pkglog.go
    deleted:    vendor/go.pedge.io/pkg/metrics/pkgmetrics.go
    deleted:    vendor/go.pedge.io/proto/LICENSE
    deleted:    vendor/go.pedge.io/proto/time/prototime.go
    deleted:    vendor/go.pedge.io/protolog/.dockerignore
    deleted:    vendor/go.pedge.io/protolog/.gitignore
    deleted:    vendor/go.pedge.io/protolog/ATTRIBUTION
    deleted:    vendor/go.pedge.io/protolog/Dockerfile
    deleted:    vendor/go.pedge.io/protolog/LICENSE
    deleted:    vendor/go.pedge.io/protolog/Makefile
    deleted:    vendor/go.pedge.io/protolog/README.md
    deleted:    vendor/go.pedge.io/protolog/benchmark/long/benchmark_long.go
    deleted:    vendor/go.pedge.io/protolog/benchmark/marshal/benchmark_marshal.go
    deleted:    vendor/go.pedge.io/protolog/circle.yml
    deleted:    vendor/go.pedge.io/protolog/defaults.go
    deleted:    vendor/go.pedge.io/protolog/gcloud/gcloud.go
    deleted:    vendor/go.pedge.io/protolog/gcloud/pusher.go
    deleted:    vendor/go.pedge.io/protolog/glog/glog.go
    deleted:    vendor/go.pedge.io/protolog/glog/pusher.go
    deleted:    vendor/go.pedge.io/protolog/logger.go
    deleted:    vendor/go.pedge.io/protolog/logrus/logrus.go
    deleted:    vendor/go.pedge.io/protolog/logrus/pusher.go
    deleted:    vendor/go.pedge.io/protolog/multi_pusher.go
    deleted:    vendor/go.pedge.io/protolog/multi_write_flusher.go
    deleted:    vendor/go.pedge.io/protolog/protolog.go
    deleted:    vendor/go.pedge.io/protolog/protolog.pb.go
    deleted:    vendor/go.pedge.io/protolog/protolog.proto
    deleted:    vendor/go.pedge.io/protolog/read_puller.go
    deleted:    vendor/go.pedge.io/protolog/syslog/pusher.go
    deleted:    vendor/go.pedge.io/protolog/syslog/syslog.go
    deleted:    vendor/go.pedge.io/protolog/testing/testing.go
    deleted:    vendor/go.pedge.io/protolog/testing/testing.pb.go
    deleted:    vendor/go.pedge.io/protolog/testing/testing.proto
    deleted:    vendor/go.pedge.io/protolog/text_marshaller.go
    deleted:    vendor/go.pedge.io/protolog/util.go
    deleted:    vendor/go.pedge.io/protolog/write_pusher.go
    deleted:    vendor/go.pedge.io/protolog/writer_flusher.go
    deleted:    vendor/golang.org/x/net/LICENSE
    deleted:    vendor/golang.org/x/net/PATENTS
    deleted:    vendor/golang.org/x/net/netutil/listen.go
    deleted:    vendor/gopkg.in/natefinch/lumberjack.v2/.gitignore
    deleted:    vendor/gopkg.in/natefinch/lumberjack.v2/LICENSE
    deleted:    vendor/gopkg.in/natefinch/lumberjack.v2/README.md
    deleted:    vendor/gopkg.in/natefinch/lumberjack.v2/chown.go
    deleted:    vendor/gopkg.in/natefinch/lumberjack.v2/chown_linux.go
    deleted:    vendor/gopkg.in/natefinch/lumberjack.v2/lumberjack.go
    deleted:    vendor/gopkg.in/tylerb/graceful.v1/.gitignore
    deleted:    vendor/gopkg.in/tylerb/graceful.v1/LICENSE
    deleted:    vendor/gopkg.in/tylerb/graceful.v1/README.md
    deleted:    vendor/gopkg.in/tylerb/graceful.v1/graceful.go
    deleted:    vendor/gopkg.in/tylerb/graceful.v1/tests/main.go

no changes added to commit (use "git add" and/or "git commit -a")
bufdev commented 8 years ago 
[~/go/src/github.com/peter-edge/go-import-server]
pedge$ git diff
diff --git a/Godeps/Godeps.json b/Godeps/Godeps.json
index 0fdcfb8..402c76a 100644
--- a/Godeps/Godeps.json
+++ b/Godeps/Godeps.json
@@ -1,6 +1,6 @@
 {
        "ImportPath": "github.com/peter-edge/go-import-server",
-       "GoVersion": "go1.5.2",
+       "GoVersion": "go1.5",
        "Packages": [
                "github.com/peter-edge/go-import-server",
                "github.com/peter-edge/go-import-server/cmd/import-server",
@@ -9,38 +9,10 @@
        ],
        "Deps": [
                {
-                       "ImportPath": "github.com/davecgh/go-spew/spew",
-                       "Rev": "5215b55f46b2b919f50a1df0eaa5886afe4e3b3d"
-               },
-               {
-                       "ImportPath": "github.com/golang/protobuf/proto",
-                       "Rev": "68415e7123da32b07eab49c96d2c4d6158360e9b"
-               },
-               {
-                       "ImportPath": "github.com/matttproud/golang_protobuf_extensions/pbutil",
-                       "Rev": "d0c3fe89de86839aecf2e0579c40ba3bb336a453"
-               },
-               {
-                       "ImportPath": "github.com/mihasya/go-metrics-librato",
-                       "Rev": "742811266180500ea5934ea6ed3313f90d806a20"
-               },
-               {
-                       "ImportPath": "github.com/pmezard/go-difflib/difflib",
-                       "Rev": "e8554b8641db39598be7f6342874b958f12ae1d4"
-               },
-               {
                        "ImportPath": "github.com/rcrowley/go-metrics",
                        "Rev": "7839c01b09d2b1d7068034e5fe6e423f6ac5be22"
                },
                {
-                       "ImportPath": "github.com/satori/go.uuid",
-                       "Rev": "d41af8bb6a7704f00bc3b7cba9355ae6a5a80048"
-               },
-               {
-                       "ImportPath": "github.com/stathat/go",
-                       "Rev": "01d012b9ee2ecc107cb28b6dd32d9019ed5c1d77"
-               },
-               {
                        "ImportPath": "github.com/stretchr/testify/assert",
                        "Comment": "v1.0-88-ge3a8ff8",
                        "Rev": "e3a8ff8ce36581f87a15341206f205b1da467059"
@@ -55,42 +27,8 @@
                        "Rev": "7bb5904005698ff870289d34e93e0fb8f433e2b9"
                },
                {
-                       "ImportPath": "go.pedge.io/google-protobuf",
-                       "Rev": "e65351045a010f78e5a00b21d2e5ce0b38f3c546"
-               },
-               {
                        "ImportPath": "go.pedge.io/pkg/http",
                        "Rev": "1680119ea77c2f7b3905dcdf91b7b656cd5ea2a1"
-               },
-               {
-                       "ImportPath": "go.pedge.io/pkg/log",
-                       "Rev": "1680119ea77c2f7b3905dcdf91b7b656cd5ea2a1"
-               },
-               {
-                       "ImportPath": "go.pedge.io/pkg/metrics",
-                       "Rev": "1680119ea77c2f7b3905dcdf91b7b656cd5ea2a1"
-               },
-               {
-                       "ImportPath": "go.pedge.io/proto/time",
-                       "Rev": "15fc26eb8d5d6ce10e2131569185723fb7356f40"
-               },
-               {
-                       "ImportPath": "go.pedge.io/protolog",
-                       "Rev": "d7eb32c165f3536687a0ebde13d49e3f0011d99f"
-               },
-               {
-                       "ImportPath": "golang.org/x/net/netutil",
-                       "Rev": "28273ec927bee3bea305f112fc28ceee575ea893"
-               },
-               {
-                       "ImportPath": "gopkg.in/natefinch/lumberjack.v2",
-                       "Comment": "v1.0-18-g600ceb4",
-                       "Rev": "600ceb4523e5b7ff745f91083c8a023c2bf73af5"
-               },
-               {
-                       "ImportPath": "gopkg.in/tylerb/graceful.v1",
-                       "Comment": "v1.2.3",
-                       "Rev": "48afeb21e2fcbcff0f30bd5ad6b97747b0fae38e"
                }
        ]
 }
bufdev commented 8 years ago

Aha! I think I found part of the bug.

Since there is a vendor directory, I do godep save $(go list ./... | grep -v vendor) This produces:

GOOS=linux GOARCH=amd64 godep save github.com/peter-edge/go-import-server github.com/peter-edge/go-import-server/cmd/import-server github.com/peter-edge/go-import-server/data github.com/peter-edge/go-import-server/testing

When I add /... to the end of each package:

$ GOOS=linux GOARCH=amd64 godep save github.com/peter-edge/go-import-server/... github.com/peter-edge/go-import-server/cmd/import-server/... github.com/peter-edge/go-import-server/data/... github.com/peter-edge/go-import-server/testing/...

This is now the git status:

[~/go/src/github.com/peter-edge/go-import-server]
pedge$ git status
On branch master
Your branch is up-to-date with 'origin/master'.
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

    modified:   Godeps/Godeps.json

Untracked files:
  (use "git add <file>..." to include in what will be committed)

    vendor/github.com/Sirupsen/
    vendor/github.com/codegangsta/
    vendor/github.com/golang/glog/
    vendor/github.com/tylerb/
    vendor/google.golang.org/

no changes added to commit (use "git add" and/or "git commit -a")

So adding /... to the end of each package makes it so that godep gets all the packages that versions <= v32 get, but also adds new ones. So my hypothesis is that versions > v32 have breaking or backwards-incompatible behavior with recursive dependencies. The above additions in the git status ARE actually external dependencies according to https://github.com/peter-edge/go-tools/tree/master/go-external-deps, but for <=v32, they were not added for whatever reason. And the code builds just fine without them in a docker container.

bufdev commented 8 years ago

I believe this is related to https://github.com/tools/godep/issues/361, I think #358 should again be opened, or we track this in one place

freeformz commented 8 years ago

After fixing some imports in my copy of that repo I was able to run a save and yes, something is broken. Looking more.

freeformz commented 8 years ago

Confirmed, closing in favor of #358