search

tools / godep

dependency tool for go
http://godoc.org/github.com/tools/godep
BSD 3-Clause "New" or "Revised" License
5.54k stars 455 forks source link

Godep stopped importing a dependency #490

Closed aanm closed 8 years ago

aanm commented 8 years ago

I'm using a dependency that imports github.com/prometheus/common

godep version godep v71 (linux/amd64/go1.6) doesn't seems to import the github.com/prometheus/common/internal/bitbucket.org/ww/goautoneg directory to vendor so I got a:

$ go install ./...
....
  imports github.com/prometheus/common/expfmt
  imports github.com/prometheus/common/internal/bitbucket.org/ww/goautoneg: use of internal package not allowed

An old godep version (I believe v62) had imported github.com/prometheus/common/internal/bitbucket.org/ww/goautoneg because the file was in vendor directory before. If I put the dependency by hand inside the vendor directory, the project compiles without any problem.

Linking to prometheus issue https://github.com/prometheus/common/issues/45

freeformz commented 8 years ago

What does your Godeps.json file look like ?

mkumatag commented 8 years ago

I also faced this issue while building k8s.io/heapster project with updated github.com/boltdb/bolt, any update on this issue?

aanm commented 8 years ago

@mkumatag can you provide a copy of your Godeps.json file so @freeformz can have a look at it? I wasn't able to reproduce the problem afterwards.

freeformz commented 8 years ago

I can't reproduce this. When I require "github.com/prometheus/common/expfmt" and godep save I get "github.com/prometheus/common/internal/bitbucket.org/ww/goautoneg" vendored. Can you explain which dep requires this? Is it vendored there? Do you have the same version vendored there on your GOPATH?

aanm commented 8 years ago

Closing this issue since the linked issue was also closed.