godep restore connects to internet even if package is in the GOPATH

bpatelcs commented 8 years ago

Expected behavior

if the dependency is in the GOPATH it should not require the internet connection, our build machines are behind the proxy and downloads are usually very slow through proxy.

Actual behavior

It seems it is downloading something not sure if it is just metadata or actual package, which makes our build really slow.

Steps to reproduce behavior

1. godep save 
2. delete everything from Godeps directory except Godeps.json file [we do not commit third party packages], these packages will in the GOPATH when we build.
3. disconnect internet
4. godep restore

`godep version` output

godep v74 (darwin/amd64/go1.6.2)

`go version` output

go version go1.6.2 darwin/amd64

Contents of Godeps.json file

  "ImportPath": “project.com/A/B/C/D",  "GoVersion": "go1.6",  "GodepVersion": "v67",  "Deps": [  {  "ImportPath": "golang.org/x/net/context",  "Rev": "6a513affb38dc9788b449d59ffed099b8de18fa0"  },  {  "ImportPath": "golang.org/x/net/context/ctxhttp",  "Rev": "6a513affb38dc9788b449d59ffed099b8de18fa0"  },  {  "ImportPath": "golang.org/x/net/http2",  "Rev": "6a513affb38dc9788b449d59ffed099b8de18fa0"  },  {  "ImportPath": "golang.org/x/net/http2/hpack",  "Rev": "6a513affb38dc9788b449d59ffed099b8de18fa0"  },  {  "ImportPath": "golang.org/x/oauth2",  "Rev": "b5adcc2dcdf009d0391547edc6ecbaff889f5bb9"  },  {  "ImportPath": "golang.org/x/oauth2/google",  "Rev": "b5adcc2dcdf009d0391547edc6ecbaff889f5bb9"  },  {  "ImportPath": "golang.org/x/oauth2/internal",  "Rev": "b5adcc2dcdf009d0391547edc6ecbaff889f5bb9"  },  {  "ImportPath": "golang.org/x/oauth2/jws",  "Rev": "b5adcc2dcdf009d0391547edc6ecbaff889f5bb9"  },  {  "ImportPath": "golang.org/x/oauth2/jwt",  "Rev": "b5adcc2dcdf009d0391547edc6ecbaff889f5bb9"  },  {  "ImportPath": "google.golang.org/cloud/compute/metadata",  "Rev": "eb47ba841d53d93506cfbfbc03927daf9cc48f88"  },  {  "ImportPath": "google.golang.org/cloud/internal",  "Rev": "eb47ba841d53d93506cfbfbc03927daf9cc48f88"  },  {  "ImportPath": "gopkg.in/inf.v0",  "Comment": "v0.9.0",  "Rev": "3887ee99ecf07df5b447e9b00d9c0b2adaa9f3e4"  },  {  "ImportPath": "gopkg.in/mgo.v2",  "Comment": "r2016.02.04-3-g29cc868",  "Rev": "29cc868a5ca65f401ff318143f9408d02f4799cc"  },  {  "ImportPath": "gopkg.in/mgo.v2/bson",  "Comment": "r2016.02.04-3-g29cc868",  "Rev": "29cc868a5ca65f401ff318143f9408d02f4799cc"  },  {  "ImportPath": "gopkg.in/mgo.v2/internal/sasl",  "Comment": "r2016.02.04-3-g29cc868",  "Rev": "29cc868a5ca65f401ff318143f9408d02f4799cc"  },  {  "ImportPath": "gopkg.in/mgo.v2/internal/scram",  "Comment": "r2016.02.04-3-g29cc868",  "Rev": "29cc868a5ca65f401ff318143f9408d02f4799cc"  },  {  "ImportPath": "gopkg.in/yaml.v2",  "Rev": "a83829b6f1293c91addabc89d0571c246397bbf4"  },  {  "ImportPath": "k8s.io/kubernetes/pkg/api",  "Comment": "v1.3.0",  "Rev": "283137936a498aed572ee22af6774b6fb6e9fd94"  },  {  "ImportPath": "k8s.io/kubernetes/pkg/api/endpoints",  "Comment": "v1.3.0",  "Rev": "283137936a498aed572ee22af6774b6fb6e9fd94"  },  {  "ImportPath": "k8s.io/kubernetes/pkg/api/errors",  "Comment": "v1.3.0",  "Rev": "283137936a498aed572ee22af6774b6fb6e9fd94"  },  {  "ImportPath": "k8s.io/kubernetes/pkg/api/install",  "Comment": "v1.3.0",  "Rev": "283137936a498aed572ee22af6774b6fb6e9fd94"  },  {  "ImportPath": "k8s.io/kubernetes/pkg/api/meta",  "Comment": "v1.3.0",  "Rev": "283137936a498aed572ee22af6774b6fb6e9fd94"  },  {  "ImportPath": "k8s.io/kubernetes/pkg/api/meta/metatypes",  "Comment": "v1.3.0",  "Rev": "283137936a498aed572ee22af6774b6fb6e9fd94"  },  {  "ImportPath": "k8s.io/kubernetes/pkg/api/pod",  "Comment": "v1.3.0",  "Rev": "283137936a498aed572ee22af6774b6fb6e9fd94"  },  {  "ImportPath": "k8s.io/kubernetes/pkg/api/resource",  "Comment": "v1.3.0",  "Rev": "283137936a498aed572ee22af6774b6fb6e9fd94"  }   ] } 

Oppodelldog commented 7 years ago

I just added a new dependency to a project after month, having the same issue. go 1.5.1, Vendorexperiment not enabled I added the new dependency to Godeps.json, godep restore works. But godep save deletes all dependcies from Godeps.json and from Godeps/_workspace.

swizzley commented 6 years ago

is there a way to use godep with a proxy?

tools / godep