tools / godep

dependency tool for go
http://godoc.org/github.com/tools/godep
BSD 3-Clause "New" or "Revised" License
5.54k stars 455 forks source link

Any idea about placing Godeps.json under vendor/ folder? #505

Closed xuxiangyang closed 6 years ago

xuxiangyang commented 8 years ago

Hi, since go:1.5 release, the official solution for dependents became use vendor folder, especially , after releasing go:1.7, there is no need for GO15VENDOREXPERIMENT env.

why Godep place Godeps.json under Godeps folder? could it place under the vendor folder? if it could work, I would like to send you a PR.

Thx

rafaeljusto commented 7 years ago

.godeps.json file in project root instead of the Godeps directory would also be cool.

AlexandreRoba commented 7 years ago

I'm not sure this would make much sense to have it in the vendor folder. Unless I'm mistaken but the vendor folder should not be under source control but the Godeps.json needs to be. Putting them in this folder would create confusion... It could be at the root level.

freeformz commented 6 years ago

I am closing this issue because the repo is going to be archived.