search

toolsplus / nx-forge

Atlassian Forge plugin for Nx
https://toolsplus.github.io/nx-forge/
MIT License
17 stars 4 forks source link

Built Forge app `package.json` contains deps of compiled Custom UI #13

Closed itsjxck closed 1 year ago

itsjxck commented 2 years ago

(Same setup context for my "Better Harvest" Forge app as my previous issue: https://github.com/toolsplus/nx-forge/issues/11)

I have just noticed the package.json of the Forge app after build contains all the dependencies of the Custom UI:

{
  "name": "better-harvest",
  "version": "0.0.0",
  "main": "index.js",
  "private": true,
  "dependencies": {
    "react": "^16.8",
    "@emotion/react": "11.9.0",
    "@forge/bridge": "^2.2.0",
    "@atlaskit/code": "^14.3.6",
    "@atlaskit/select": "^15.2.12",
    "react-dom": "^16.8",
    "@atlaskit/spinner": "^15.1.10",
    "@atlaskit/inline-edit": "^12.1.12",
    "@atlaskit/theme": "^12.1.7",
    "@atlaskit/css-reset": "^6.3.11",
    "@forge/resolver": "^1.4.3",
    "@forge/api": "^2.6.1"
  }
}

This is probably not desirable as at the stage of the process where the Forge app itself gets built, the Custom UI already statically bundled and therefore no longer has any dependencies on these packages.

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version 1.3.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: