search

toolsplus / nx-forge

Atlassian Forge plugin for Nx
https://toolsplus.github.io/nx-forge/
MIT License
17 stars 4 forks source link

fix(build): fix Forge app build to keep external dependencies external #18

Closed tbinna closed 2 years ago

tbinna commented 2 years ago

fix Forge app build to ensure Webpack does not bundle external dependencies

Closes: #17

tbinna commented 2 years ago

This simple fix seems to work based on my testing. It seems that Webpack still bundles internal Nx project dependencies (such as lib projects) and only externalizes node_modules (which is what we want).

The only issue with this solution is that the Forge linter now produces the following result:

Warning: Could not perform some linting actions for HandlerLinter due to unhandled error "Cannot read properties of undefined (reading 'forEach')".

I guess we will have to dig into the compiled Forge linter code to try to understand why that is.

tbinna commented 2 years ago

The linter issue is currently being discussed here: https://community.developer.atlassian.com/t/unclear-forge-linter-warning/58465

tbinna commented 2 years ago

Atlassian indicates that the warning is an issue in the Forge linter that will be resolved.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.1.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: