toolsplus / nx-forge

Atlassian Forge plugin for Nx
https://toolsplus.github.io/nx-forge/
MIT License
17 stars 4 forks source link

Bump to NX 17.2.8 #54

Closed jackgraves closed 8 months ago

jackgraves commented 8 months ago

This updates the library to be compatible with the latest Nx version as requested in #53

Allows us to keep getting all the juicy Nx updates and performance improvements.

I've removed some of the previous logic around ESLint which should be re-added, but needs further work as the way this is done has been changed. I think the @nx/js library build executor can be used as a template for re-adding this functionality.

This would require that users update their Nx monorepo to latest version by running nx migrate latest and following the instructions - so it must be published as a new major version (e.g. 3.0.0-beta) - please let me know how you're managing the versioning 👍🏼

tbinna commented 8 months ago

Thanks for the PR, @jackgraves.

A few comments:

Versioning is handled automatically by semantic release which computes the version based on the commit messages. In this case, there should be a breaking change tag in the commit message to indicate a breaking release (similar to the commit here).

I will check if we can fix some of the outstanding issues.

tbinna commented 8 months ago

Fixed in #56