Closed jackgraves closed 8 months ago
Thanks for the PR, @jackgraves.
A few comments:
sourceMap
parameter should go into a separate PRmigrations.json
file. It's only required if other branches in this repo need to run the migration scripts but that's not the case herepackage.json
require version ^17.0.0, unless we are using some APIs that require a specific Nx versionVersioning is handled automatically by semantic release which computes the version based on the commit messages. In this case, there should be a breaking change tag in the commit message to indicate a breaking release (similar to the commit here).
I will check if we can fix some of the outstanding issues.
Fixed in #56
This updates the library to be compatible with the latest Nx version as requested in #53
Allows us to keep getting all the juicy Nx updates and performance improvements.
I've removed some of the previous logic around ESLint which should be re-added, but needs further work as the way this is done has been changed. I think the @nx/js library build executor can be used as a template for re-adding this functionality.
This would require that users update their Nx monorepo to latest version by running
nx migrate latest
and following the instructions - so it must be published as a new major version (e.g. 3.0.0-beta) - please let me know how you're managing the versioning 👍🏼