toolsplus / nx-forge

Atlassian Forge plugin for Nx
https://toolsplus.github.io/nx-forge/
MIT License
17 stars 4 forks source link

Fix an issue where nx-forge is complaining about missing dependencies #57

Closed tbinna closed 8 months ago

tbinna commented 8 months ago

Remove an accidental dependencies declaration in the package.json in the nx-forge plugin directory. This slipped in the last release.

github-actions[bot] commented 8 months ago

:tada: This issue has been resolved in version 3.0.0-beta.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

tbinna commented 8 months ago

Nx removed the updateBuildableProjectDepsInPackageJson option in the @nx/js:tsc executor in Nx 17. This option was used to add the dependencies to the package.json. According to some posts, e.g., this one, this option was hard to support, so they removed it.

The replacement is the Nx ESLint dependency-checks plugin (see also here), which has fixers to add missing dependencies, report obsolete ones, or the ones that have version mismatches.

To fix this, we should set up the dependency-checks plugin, add the dependencies to the package.json, and let the linter verify the dependency declarations. This way it's easier to control which declarations are peer deps and which ones are regular deps.

github-actions[bot] commented 8 months ago

:tada: This issue has been resolved in version 3.0.0-beta.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 8 months ago

:tada: This issue has been resolved in version 3.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: