search

toolsplus / nx-forge

Atlassian Forge plugin for Nx
https://toolsplus.github.io/nx-forge/
MIT License
17 stars 4 forks source link

Ensure plugin dependencies #76

Closed tbinna closed 4 months ago

tbinna commented 4 months ago

If you follow the Getting started guide without the Custom UI part (i.e. without installing the @nx/react plugin), then building a generated Forge app will fail because the @nx/webpack plugin is missing.

This can easily be fixed by adding the @nx/webpack plugin. However, we should make sure that the application generator ensures the @nx/wepack dependency is installed. This can be achieved via the ensurePackage method of the Nx DevKit.

If we can do this for all required dependencies we can probably remove most peer dependency declarations.

tbinna commented 4 months ago

Closing this issue. After some testing, the reported issue seems not reproducible. The plugin has a dependency on @nx/webpack and works as expected.