search

toolsplus / nx-forge

Atlassian Forge plugin for Nx
https://toolsplus.github.io/nx-forge/
MIT License
17 stars 4 forks source link

Fix an issue where processing Custom UI dependencies fails for inferred build targets #96

Closed tbinna closed 4 months ago

tbinna commented 4 months ago

This issue affects both the build and the package executors.

The processing of Custom UI dependencies assumes that the Custom UI project's build target has an options.outputPath property. However, with inferred targets, the output path is defined in the tooling itself.

There is no obvious way to get the build output path without the plugin knowing about the specifics of each build tool. An alternative may be to try to read outputs[0] of the project configuration, which typically defines the build output for caching purposes. However, this is not a deterministic solution, as other catchable outputs could be defined.

The idea to fix this is to add a resourceOutputPathMap configuration parameter, which is an object that maps project names to their output path. If defined, the plugin process may use this mapping, if not it could try to look for options.outputPath or as a last resort outputs[0] if there is only one entry.

github-actions[bot] commented 4 months ago

:tada: This issue has been resolved in version 4.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: