toolstack / Folio

A beautiful markdown note-taking app for GNOME (forked from Paper)
GNU General Public License v3.0
139 stars 12 forks source link

[Enhancement] Attach, Display Images, Files #27

Open LSeelig opened 4 months ago

LSeelig commented 4 months ago

My workflow involves mostly text notes I can make in Markdown, but there are some notes that require handwriting. I use an ipad app that exports SVGs.

Being able to embed displayable files (images, vector graphics, maybe even PDFs?) would be great.

I also would like some way to control/default width so that the handwritten text is at a decent scale. My notes expand downwards, so the final image/vector is extremely tall, but the width should match roughly the width of a paragraph text.

toolstack commented 4 months ago

While it's possible to make images appear in the editor, they would have to be somewhere external to the notes themselves (perhaps a file:// link would be possible).

This will not be a nigh priority item and the ability to control the attribute of the image would be even more complex so while I'll leave this open, I don't expect it to move forward anytime soon.

frandavid100 commented 4 months ago

Would it be possible to add links to different notes?

toolstack commented 4 months ago

Would it be possible to add links to different notes?

That seems like it should be doable.

prog-amateur2 commented 4 months ago

This will not be a nigh priority item and the ability to control the attribute of the image would be even more complex so while I'll leave this open, I don't expect it to move forward anytime soon.

On the contrary, I think it would be a huge advance over the rest of the note applications out there. Many use notes under images from the web or screenshots (personally, I used to take notes with Paper for online courses and was frustrated not to be able to integrate images into my notes). You can imagine a use case for many things :

This feature would make Folio the equivalent of One Note (in terms of ergonomics) on Linux, with the advantage of Markdown.

Paper wanted to offer this (c.f. here) but unfortunately was already on the downhill slope in terms of support.

PS : I really thank you to take over this wonderful app. Paper was so good, I enjoy your kindness to continue the support in Folio.

toolstack commented 4 months ago

I don't disagree that this feature would be useful, just that it is hard to implement with the current display engine and things like annotations etc are simply not doable at all.

Due to that complexity and those limitations, it's low priority for me as there are lots of other things to fix that are easier/possible, and I would not be using this functionality myself anyway.

Of course if someone wants to provide a PR with the feature I'd be completely open to it 😉

wada3n commented 3 months ago

Hi @toolstack , In this context, rather than including attachments and images directly within notes, consider adding a sidebar. A similar application called Noteworthy allows users to seamlessly attach images, voice notes, and other files to the note. These attachments remain accessible whenever needed, without cluttering the main note itself.” Screenshot from 2024-03-31 14-54-56

toolstack commented 3 months ago

I think inline images are doable, but I am a little concerned around the security implications of downloading remote data, so I have to put some thought into that.

I don't personally think a sidebar style link list makes much sense for markdown documents.

LSeelig commented 3 months ago

Images and graphics can typically be embedded into the markdown document and they displayed on the pages. What if, you simply allowed an attached image to act as a page, replacing a markdown document? This would fulfill my use case, as I could attach my digital stylus notes as pages for work I cannot type.

toolstack commented 3 months ago

I will be adding image support, but I'm not willing to "break" the markdown standard.

Perhaps what I implement will be close enough, as if you have a single image link in the markdown document it will effectively just display the linked image.

LSeelig commented 3 months ago

I will be adding image support, but I'm not willing to "break" the markdown standard.

Perhaps what I implement will be close enough, as if you have a single image link in the markdown document it will effectively just display the linked image.

Actually, I realize Folio already restricts text width. Will you display images at full size or sized to fit the width (when wider than the width)? That would be ideal!

toolstack commented 3 months ago

@LSeelig When width is restricted (which is optional, see the preferences), I would expect the image to be similarly restricted.