search

toomuchio / plex-nginx-reverseproxy

Configuration to serve Plex Media Center https://plex.tv using Nginx https://nginx.com
663 stars 94 forks source link

Duplicate MIME type error fix #18

Closed DenzoNL closed 7 years ago

DenzoNL commented 7 years ago

The text/html argument for gzip_types causes an error as it is included by default, something like this:

2017/04/26 09:53:12 [warn] 11022#11022: duplicate MIME type "text/html" in /etc/nginx/sites-enabled/my.domain.com:56

The commit included removes the argument, and works fine :)

toomuchio commented 7 years ago

Not so much an error as a harmless warning, I liked it as it was implicit should it ever be removed as a default. Might consider removing it. It's a personal preference.

HLFH commented 6 years ago

I was thinking to make a PR to fix this redundancy issue, but apparently you have chosen the won't fix status.

Responses with the “text/html” type are always compressed.

Please keep us in the loop when you'll reconsider it. Otherwise, we'll have to fork this conf, and then avoid to speak with upstream.

toomuchio commented 6 years ago

I removed this today, it's not a redundancy issue, it's not an issue at all the reason I had it is to be specific should this be removed from the Nginx defaults later.

I personally think it's stupid it's set by default and it warns if you re-specific it, the warning is harmless and never created any issues but I'll cave since it was a personal preference.

Should nginx remove it as a default at some point hopefully somebody will be in the loop enough to send a pull request.