search

toonvanstrijp / nestjs-i18n

The i18n module for nestjs.
https://nestjs-i18n.com
Other
652 stars 112 forks source link

Update .npmignore #431

Closed rubiin closed 1 year ago

rubiin commented 1 year ago

removes unwanted files from published package The current package size is 3.9MB . After inspecting , I found some files that are not needed in the final library build are also exported on the package.

After removing the unwanted files like docs and static assets, the library size goes down to 85KB which is a great reduction in size

rubiin commented 1 year ago

@toonvanstrijp

coveralls commented 1 year ago

Coverage Status

Coverage remained the same at 91.761% when pulling 1777865bfc0f9dbcda5e0bc928a9aa7d54bab76a on rubiin:main into a943462a4979c16157442d49a973a1ffa5592dad on toonvanstrijp:main.

toonvanstrijp commented 1 year ago

@rubiin thanks! 🎉

rubiin commented 1 year ago

will this be released soon? Will help speed up my builds

toonvanstrijp commented 1 year ago

I'll make one in a bit! ;)

toonvanstrijp commented 1 year ago

Released in V10.2.0 🎉

SchroederSteffen commented 1 year ago

Just saw this, this is great! 👍 (I also planned to raise this at some point.)

FYI: Instead of the .npmignore which acts as an "exclude list", you could also use the files property of the package.json which acts as an "include list". This avoids having to add new dev & test files in the future, because usually you would just include the dist folder and you're done.