search

toonvanstrijp / nestjs-i18n

The i18n module for nestjs.
https://nestjs-i18n.com
Other
642 stars 106 forks source link

chore: upgrade @nestjs/apollo v11 #477

Closed 9renpoto closed 1 year ago

9renpoto commented 1 year ago

upgrade @nestjs/apollo

ref: https://docs.nestjs.com/graphql/migration-guide

toonvanstrijp commented 1 year ago

@9renpoto can you take a look at the failing test?

9renpoto commented 1 year ago

@toonvanstrijp Thanks for running the test. I am just trying to migrate and need help with the same error.

I'm willing to take over and investigate, but if you have any good ideas, I'd appreciate your support :)

coveralls commented 1 year ago

Coverage Status

Coverage: 90.884%. Remained the same when pulling a9ba2c54612eed00ba4c27870b9e04223a6eb734 on g59:main into 1a86bb46e9386c6450d10c9c9e609f78315752d0 on toonvanstrijp:main.

9renpoto commented 1 year ago

@toonvanstrijp Fixed issue with custom errors not being caught. Please review it :)

toonvanstrijp commented 1 year ago

@9renpoto there is still one test failing? I don't have time today to look at it in detail, but I'll make some time for it this weekend.

9renpoto commented 1 year ago

This change is slightly out of date. It will be reworked when the opportunity arises.