search

toonvanstrijp / nestjs-i18n

The i18n module for nestjs.
https://nestjs-i18n.com
Other
656 stars 113 forks source link

build: check format & lint in GitHub workflow #670

Closed SchroederSteffen closed 1 month ago

SchroederSteffen commented 1 month ago

Description

While preparing another change, I noticed that the lint script doesn't work and that there are formatting issues in the code. Both could be detected if the GitHub workflow test would also lint & check the formatting. This is added by this PR.

I also added a verify script to be able to easily execute all relevant scripts locally.

To get the build green, we also need to format the code in this PR. I'd suggest to extract these formatting changes into another PR which should be merged before this one (#670).

Additional context

The current lint script eslint '{src,apps,libs,test}/**/*.ts' runs into the following error:

> eslint '{src,apps,libs,test}/**/*.ts'

Oops! Something went wrong! :(

ESLint: 8.49.0

No files matching the pattern "'{src,apps,libs,test}/**/*.ts'" were found.
Please check for typing mistakes in the pattern.
coveralls commented 1 month ago

Coverage Status

coverage: 90.821% (+0.02%) from 90.805% when pulling ecce5cfc49423cbf8d03c7d21b481a1481fd1341 on SchroederSteffen:check-format-lint-github-workflow into fb35d52d336a5b3644b0f677ac95117d03b2d86b on toonvanstrijp:main.