search

tooolbox / node-potrace

JavaScript port of Potrace, for NodeJS
GNU General Public License v2.0
388 stars 34 forks source link

fix: trim "path" #3

Closed privatenumber closed 4 years ago

privatenumber commented 4 years ago

The calculated path always had a trailing space behind it.

pklauzinski commented 4 years ago

Ran into this issue as well. Any chance this PR can be merged?

tooolbox commented 4 years ago

Looks good to me.

tooolbox commented 4 years ago

@Iwasawafag you'll need to pull this in & publish I suppose.

privatenumber commented 4 years ago

Hard to tell which repo is the source of truth, @tooolbox or @Iwasawafag s.

For what it's worth, I made the PR against @tooolbox 's because the npm package potrace is by mattmc (@tooolbox), which is what my packages depend on.

pklauzinski commented 4 years ago

Yep, this is the repo for the registered NPM package, and it gets a lot of downloads too.

@tooolbox I see you bumped the version.. if you publish it to NPM that should update the package.

Or does @Iwasawafag own the NPM account? This is confusing.

tooolbox commented 4 years ago

I added him as an owner on NPM a while ago, as I didn't want to maintain it. But it doesn't seem that he's been amazing about accepting PRs, or answering pings on GitHub.

It has been a long time since I've published anything on NPM, but I figured it out and published v2.1.4.

pklauzinski commented 4 years ago

Thank you, sir!