tooolbox / node-potrace

JavaScript port of Potrace, for NodeJS
GNU General Public License v2.0
388 stars 34 forks source link

Upgrade Jimp to address minimist security vuln. #5

Closed karlhorky closed 4 years ago

karlhorky commented 4 years ago

Since the pull request for Jimp addressing minimist security vulnerability (https://www.npmjs.com/advisories/1179) was accepted, it would be good to upgrade to at least 0.9.6:

https://github.com/oliver-moran/jimp/pull/857

Original fix in mkdirp: https://github.com/isaacs/node-mkdirp/issues/7#issuecomment-600231795

It seems like the last minor releases have not changed anything breaking...?

If this is accepted and released as a minor or patch, this will also enable Gatsby projects to fix the security issues without breaking semver, since gatsby-plugin-sharp and gatsby-transformer-sharp depend on potrace@^2.1.2:

tooolbox commented 4 years ago

https://www.npmjs.com/package/potrace/v/2.1.5

karlhorky commented 4 years ago

Thanks @tooolbox!

Looks like this is already in the next Gatsby pull request to bump dependencies: gatsbyjs/gatsby#22434

Edit: Ah, Gatsby was actually upgraded separately, in this pull request. These patch versions are the versions to look for: