toor1245 / MatrixDotNet

Powerful .NET library for calculating matrix
https://toor1245.github.io/MatrixDotNet/
MIT License
10 stars 3 forks source link

Implement ExceptionArgument #133

Closed toor1245 closed 3 years ago

Dilorfin commented 3 years ago

As temp solution it's better than was before, but I think specific exceptions will be better

Dilorfin commented 3 years ago

Several questions about base MatrixDotNetException class

As for me Console.ForegroundColor isn't something that expected to change while catching exceptions. May be it should be removed?

With all these changes, how often are used argument2 and argument2?

What about best practices [link]? I'm even not talking about inheriting from .net ArgumentException... Why not possible to write smth like:

try {
    ...
} catch (MatrixDotNetException e) {
    throw new MatrixDotNetException("MyMessage", e);
}
toor1245 commented 3 years ago

Several questions about base MatrixDotNetException class

As for me Console.ForegroundColor isn't something that expected to change while catching exceptions. May be it should be removed?

With all these changes, how often are used argument2 and argument2?

What about best practices [link]? I'm even not talking about inheriting from .net ArgumentException... Why not possible to write smth like:

try {
    ...
} catch (MatrixDotNetException e) {
    throw new MatrixDotNetException("MyMessage", e);
}

As I remember, argument1 and argument used a long time ago, so we can easily delete this properties, and yes we can delete foreground:)