search

tootcafe / discussions

General forum to discuss issues with Toot Café that don't fit into any other repo
8 stars 0 forks source link

Problems signing up with the new passphrase-based system #27

Open nolanlawson opened 7 years ago

nolanlawson commented 7 years ago

Many folks are reporting what appear to be cookie/redirect issues with our new passphrase-based registration system:

As someone reported on Twitter:

When I clicked the verify email link it seemed to work but then somehow it forwarded me back to the signup page. And then told me the email verification failed (it asked if I was blocking cookies). On reload, it auto-logged me in straight into the homepage. Not a big deal, it might have been to do with multiple tabs – I had the verification page open when I first signed up, but then the link from my email opened another effectively identical page.

The relevant PRs are here: tootcafe/mastodon#9 tootcafe/mastodon#10 . Some help fixing this would be appreciated, since I'm not super familiar with Ruby. :smiley: That PR can be tested in a local Mastodon development environment.

Seebiscuit commented 7 years ago

This may be happening when a user navigates to toot.cafe/auth/signin when they are already signed in right after going through Confirmation...

b2m9 commented 7 years ago

I had the exact same behaviour. I had one tab open, when the email arrived. I didn't reload the confirmation page, but went directly to toot.cafe and all was well.

NickBarreto commented 7 years ago

@b2m9 that sounds like you've reproduced it exactly. That report from twitter above was me, and it pretty accurately describes what I was doing. I think @Seebiscuit's point is relevant, but worth noting that going to toot.cafe/auth/signin wasn't deliberate – the user gets redirected/forwarded there automatically, I think, which may be the issue. If the redirect/forward goes to toot.cafe, it may avoid the problem entirely.

nolanlawson commented 7 years ago

Hm, I'm wondering what in our code could possibly be causing this. I've never heard this reported by users of other Mastodon instances. Our change is so innocuous I really am not sure what the issue is here: tootcafe/mastodon#9 tootcafe/mastodon#10

nolanlawson commented 7 years ago

Also I never got reports of this before merging those PRs, so I'm guessing it must be something related to that.