toots / shine

Super fast fixed-point MP3 encoder with JS/wasm and android native bindings.
Other
396 stars 63 forks source link

fix issue #11, segfault in shine_BF_freePartHolder #12

Closed felixmulder closed 10 years ago

felixmulder commented 10 years ago

config->formatbits.side_info.headerPH and config->formatbits.side_info.frameSIPH are allocated at the same time thus checking one of them should be sufficient to ensure that an unsafe free is not performed. Other solutions would be to check for NULL in shine_BF_freePartHolder, but this is faster.