codecov-commenter
commented
1 month ago :warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.
Project coverage is 12.26%. Comparing base (
e35f497) to head (454099a). Report is 34 commits behind head on 3.0.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## 3.0 #596 +/- ## ============================================ + Coverage 12.24% 12.26% +0.01% - Complexity 2965 2980 +15 ============================================ Files 64 64 Lines 7129 7150 +21 ============================================ + Hits 873 877 +4 - Misses 6256 6273 +17 ``` | [Flag](https://app.codecov.io/gh/top-think/think-orm/pull/596/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=top-think) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/top-think/think-orm/pull/596/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=top-think) | `12.26% <0.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=top-think#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hhh0121
liu21st
1.hasWhere和where方法同时使用，没有自动加别名
2.对关联模型的软删除查询有问题，如果hasWhere闭包里写的有or查询会导致软删除查询限制无效
3.where方法传入query类的时候，会清空替换掉前面的查询条件
优化如下：增加默认查询条件下的字段别名，去除关联模型的软删除查询（像withjoin和join都不支持都对关联模型的软删除查询），hasWhere函数内where增加闭包（支持和where方法同时使用）