top-think / think-orm

Think ORM——the PHP Database&ORM Framework
Apache License 2.0
413 stars 171 forks source link

兼容 PHP 8.4 top-think/framework#3026 #612

Closed big-dream closed 3 weeks ago

big-dream commented 3 weeks ago

https://github.com/top-think/framework/pull/3044

big-dream commented 3 weeks ago

奇怪,本地跑单元测试没问题。


看来是这个提交导致的 https://github.com/top-think/think-orm/commit/34e3f8f75020d3ed00603f687b51a4d2fce01725

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 5.16129% with 147 lines in your changes missing coverage. Please review.

Project coverage is 17.42%. Comparing base (e35f497) to head (681eb0a). Report is 80 commits behind head on 3.0.

Files Patch % Lines
src/Model.php 9.09% 10 Missing :warning:
src/db/BaseQuery.php 9.09% 10 Missing :warning:
src/model/concern/RelationShip.php 0.00% 9 Missing :warning:
src/db/Where.php 0.00% 8 Missing :warning:
src/model/relation/BelongsTo.php 0.00% 8 Missing :warning:
src/model/relation/BelongsToMany.php 0.00% 8 Missing :warning:
src/model/relation/HasMany.php 0.00% 8 Missing :warning:
src/model/relation/HasManyThrough.php 0.00% 8 Missing :warning:
src/model/relation/MorphMany.php 0.00% 8 Missing :warning:
src/model/relation/HasOne.php 0.00% 7 Missing :warning:
... and 22 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## 3.0 #612 +/- ## ============================================ + Coverage 12.24% 17.42% +5.17% - Complexity 2965 3005 +40 ============================================ Files 64 64 Lines 7129 7209 +80 ============================================ + Hits 873 1256 +383 + Misses 6256 5953 -303 ``` | [Flag](https://app.codecov.io/gh/top-think/think-orm/pull/612/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=top-think) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/top-think/think-orm/pull/612/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=top-think) | `17.42% <5.16%> (+5.17%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=top-think#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

liu21st commented 3 weeks ago

建议等正式发布8.4后 统一处理下兼容性问题

big-dream commented 3 weeks ago

好的,那先暂时关闭