search

topaz-next / topaz

💎 A server emulator for Final Fantasy XI.
GNU General Public License v3.0
55 stars 81 forks source link

X2 Guild point KI bought/Missing KI when bought #1038

Open topaz-next-bot opened 3 years ago

topaz-next-bot commented 3 years ago

Issue by topaz-bot Wednesday Jan 08, 2020 at 15:04:34 Originally opened as: project-topaz/topaz - Issue 294

Issue by AppleCrumble1 Friday May 17, 2019 at 11:45 GMT Originally opened as DarkstarProject/darkstar - Issue 6012

I have:

Client Version 31090328_2

Source Branch (master/stable) : master

Additional Information

I had 20k Guild points for smithing guild, I wanted to buy Chainwork and Sheeting KI's both 10k guild points each. I bought Sheeting KI and spenk 10k guild points and then Chainwork vanished from the KI list but Sheeting remained, Thought maybe it was a text id bug so tried to buy the second Sheeting hoping it would give Chainwork. It took the remaining 10k guild points and gave me Sheeting again. Checked my perm KI list and only showed sheeting once. Was rectified by GM to give Chainwork in game

topaz-next-bot commented 3 years ago

Comment by topaz-bot Wednesday Jan 08, 2020 at 15:04:35

Comment by AppleCrumble1 Friday May 17, 2019 at 11:49 GMT

We run Master Source Branch so Teo just informed me.

topaz-next-bot commented 3 years ago

Comment by topaz-bot Wednesday Jan 08, 2020 at 15:04:36

Comment by ibm2431 Sunday May 19, 2019 at 08:08 GMT

Saving people some time: github/DarkstarProject/darkstar/blob/dbaaa7710698a4e41e3175b6f3e80fc59e671d98/scripts/globals/keyitems.luaDarkstar Issue L1982-L1983 (These IDs checked out when I used !addkeyitem 1994 and !addkeyitem 1995)

github/DarkstarProject/darkstar/blob/dbaaa7710698a4e41e3175b6f3e80fc59e671d98/scripts/zones/Metalworks/npcs/Lorena.luaDarkstar Issue L22-L31

github/DarkstarProject/darkstar/blob/dbaaa7710698a4e41e3175b6f3e80fc59e671d98/scripts/zones/Northern_San_dOria/npcs/Macuillie.luaDarkstar Issue L22-L31

Suspect the issue might be in here (maybe mismatched bit-shifting), but I don't know how this menu is supposed to work: github/DarkstarProject/darkstar/blob/dbaaa7710698a4e41e3175b6f3e80fc59e671d98/scripts/globals/crafting.luaDarkstar Issue L243-L253 While fixing this, should probably also add a safety check that the player doesn't already possess the KI before trying to give it to them.