search

topaz-next / topaz

💎 A server emulator for Final Fantasy XI.
GNU General Public License v3.0
55 stars 81 forks source link

avatar hitrate baaaaaaaaaaad #1754

Open topaz-next-bot opened 3 years ago

topaz-next-bot commented 3 years ago

Issue by TeoTwawki Thursday Aug 27, 2020 at 15:28:26 Originally opened as: project-topaz/topaz - Issue 1011

I have:

Additional Information (Steps to reproduce/Expected behavior) : https://github.com/project-topaz/topaz/blob/release/scripts/globals/summon.lua#L55

if math.random() < hitrate then

that check as is will pretty much always pass because its rolling a floating point form 0 to 1, which is always less than what the hitrate will be.

But if we fix it you go from always hitting to always missing because: local hitrate = utils.clamp(acc - eva, 20, 95) is always returning around 20. Avatar acc is garbage while mob eva is not. It would probably help if avatars weren't statted like taru(*1) blm(*2), a combination not known for its amazing acc stat.

topaz-next-bot commented 3 years ago

Comment by 59blargedy Thursday Aug 27, 2020 at 16:28:04

adding some more information here avatar accuracy = (first hit bonus acc if first hit(100) + accuracy from combat skill (A-) + master summoning skill over cap (1:1 mapping skill to acc) + master pet accuracy gear + avatar job acc traits + ((avatar dex *.5 + summoner merits (3 acc per)) avatars get a first hit bonus of 100 acc so need to factor that in as well

hitrate would be: 75 + (acc-eva)/2 if mob is higher than avatar, then 75 + (acc-eva)/2 - 2*(target level - attacker level)

topaz-next-bot commented 3 years ago

Comment by TeoTwawki Thursday Aug 27, 2020 at 18:26:29

so looking over avatar's tp skills scripts and the 2 globals (it goes into the monstertpmoves global as well)..there are multiple other issues to, like hard coded pet ID ranges instead of exposing petType to lua and effectively checking for things like stoneskin twice.

the entire flow(pun not intended) could use an overhaul.

topaz-next-bot commented 3 years ago

Comment by 59blargedy Thursday Aug 27, 2020 at 20:47:37

yeah for sure, it is in a bit of a mess. baby steps?

topaz-next-bot commented 3 years ago

Comment by TeoTwawki Thursday Aug 27, 2020 at 20:53:55

yeah for sure, it is in a bit of a mess. baby steps?

and lots of them. I have a few minor ones incoming.