Populate Guild Shops

[topaz-next-bot]

Issue by jarmengaud Sunday Sep 13, 2020 at 17:17:24 Originally opened as: project-topaz/topaz - Issue 1129

---

I affirm:

• [x] that I agree to Project Topaz's Limited Contributor License Agreement, as written on this date
• [x] that I've tested my code since the last commit in the PR, and will test after any later commits

Fixes #201

Remove guild holidays as per retail Uncomment guild shops items that were removed because an old 30-item limit

There is still work to try to find exact prices from retail (wiki data are very approximative!) However note that the Mhaura/Selbina/Al zhabi guilds already had most of the restocked items, not commented out

[topaz-next-bot]

Comment by kaincenteno Monday Sep 14, 2020 at 18:13:10

---

Can this be instead a setting that can be handled as a global in settings.lua?

I ask cuz oldschool servers might not want to have this current QoL change, right @TeoTwawki ?

[topaz-next-bot]

Comment by TeoTwawki Monday Sep 14, 2020 at 18:15:19

---

Old school servers would have already had to customize this coz it was never retail accurate even for the old system

[topaz-next-bot]

Comment by zach2good Tuesday Sep 15, 2020 at 06:28:51

---

I know nothing about guilds and crafting, so I can only comment on code and style etc. All looks pretty sane, this is one of the rare cases where I'm in favor of leaving the old code around with a comment saying "this was removed in 2014" in case people want to revert it.

We can make some allowances and settings to help people that want to run era servers, but we can't be expected to do that for every possible thing that's changed between 2006 and now. If yet another person wants to spin up a TOAU-era server, then they can expect to do at least a little bit of work.

Happy to sign off on this if it gets a couple of "yes" votes.

[topaz-next-bot]

Comment by kaincenteno Tuesday Sep 15, 2020 at 07:08:14

---

Yes

[topaz-next-bot]

Comment by jarmengaud Tuesday Sep 15, 2020 at 08:55:11

---

Let me clear some confusion: this is not at all a QoL...! The understanding of what happened, as I understand it: Before the big crafting change from SE (2014?), there were 2 guild shops per guild in main cities. Selling the same thing.

DSP had an issue with more than 30 items per shop, so they split the big list between those 2 NPCs.

When SE changed the crafting, the left hand side NPC turned into a normal shop, selling the kits + materials depending on your rank. But for DSP/Topaz it meant there were only 1 guild NPC left. And all the restocked items were missing as they usually were on the left hand side NPC! (thats why we have empty shops at the moment).

The PR consists of putting back the complete original list on the remaining NPC.

If you would like an era-like system, you would have to revert also the left hand side NPC.

[topaz-next-bot]

Comment by zach2good Saturday Sep 19, 2020 at 12:30:22

---

It seems like this is fixes something that wasn't era - so it doesn't serve era servers, and isn't retail - so it doesn't serve the goal of matching retail. Seems like a win to me 🤷