topaz-next / topaz

💎 A server emulator for Final Fantasy XI.
GNU General Public License v3.0
55 stars 81 forks source link

San d’Oria Mission 2-2 "The Davoi Report" If the mission is received a second time, it cannot be completed / Wrong NPC message / wrong direction of NPC. #1981

Open topaz-next-bot opened 3 years ago

topaz-next-bot commented 3 years ago

Issue by eyes-and-brain Saturday Oct 03, 2020 at 05:03:36 Originally opened as: project-topaz/topaz - Issue 1238


I have:

Additional Information (Steps to reproduce/Expected behavior) :

Wrong NPC message.

https://github.com/project-topaz/topaz/blob/7adb2f5daffdd497b763c58b986783d39e7a6664/scripts/zones/Davoi/npcs/Zantaviat.lua#L15-L32

if (CurrentMission == tpz.mission.id.sandoria.THE_DAVOI_REPORT and player:getCharVar("MissionStatus") == 0) then
    player:startEvent(100)
elseif (CurrentMission == tpz.mission.id.sandoria.THE_DAVOI_REPORT) then
    if (player:hasKeyItem(tpz.ki.LOST_DOCUMENT)) then
        player:startEvent(104)
    elseif (player:hasKeyItem(tpz.ki.TEMPLE_KNIGHTS_DAVOI_REPORT)) then
        player:showText(npc, ID.text.AAAA);
    else
        player:showText(npc, ID.text.BBBB);
    end
elseif (CurrentMission == tpz.mission.id.sandoria.INFILTRATE_DAVOI and infiltrateDavoi and player:getCharVar("MissionStatus") == 0) then
    player:startEvent(102)
elseif (CurrentMission == tpz.mission.id.sandoria.INFILTRATE_DAVOI and player:getCharVar("MissionStatus") == 9) then
    player:startEvent(105)
else
    player:startEvent(101)
end

"ID.text.AAAA" has the value "7410". "ID.text.BBBB" has the value "7485".

wrong direction of NPC. The retail NPC "Xanthavia" is hiding behind a tree. Topaz's NPC 'Xanthaviat' is facing the opposite direction and is not hiding behind a tree.

topaz-next-bot commented 3 years ago

Comment by eyes-and-brain Sunday Oct 04, 2020 at 06:11:22


wrong direction of NPC. The retail NPC "Xanthavia" is hiding behind a tree. Topaz's NPC 'Xanthaviat' is facing the opposite direction and is not hiding behind a tree.

I would like to add to the above. The initial orientation of the NPCs is correct.

If player talk to the "Zantaviat", the NPC rotates its direction to the player's direction. The problem is that the direction of the NPC "Zantaviat" does not return to its original orientation afterwards. The problem may be that using player:showText causes the NPC's orientation to rotate in the direction of the player.

topaz-next-bot commented 3 years ago

Comment by eyes-and-brain Sunday Oct 04, 2020 at 06:59:08


When the mission "The Davoi Report" is received more than twice, the following steps must be repeated.

However, the current implementation of topaz does not seem to support repeating this mission more than twice. The mission doesn't progress even after talking to the NPC "Zantaviat". When I talk to a guard NPC "Ambrotien", I get a fanfare for completing the mission, but the mission status is still in progress. It will be impossible to complete any other San d'Oria missions in the future.