Wyvern Breath fixed to display ability name not hard coded value

topaz-next / topaz

💎 A server emulator for Final Fantasy XI.

GNU General Public License v3.0

55 stars 81 forks source link

Wyvern Breath fixed to display ability name not hard coded value #2001

Closed topaz-next-bot closed 3 years ago

topaz-next-bot commented 3 years ago

Issue by nsabott Monday Oct 05, 2020 at 19:11:38 Originally opened as: project-topaz/topaz - Issue 1258

Wyvern breaths should be coded using the ability name not hard coded with the number, as this causes it to be mismatched if the ability values change

I affirm:

[x] that I agree to Project Topaz's Limited Contributor License Agreement, as written on this date
[x] that I've tested my code since the last commit in the PR, and will test after any later commits

topaz-next-bot commented 3 years ago

Comment by zach2good Tuesday Oct 06, 2020 at 06:21:47

Hey! Please co-ordinate with @rude-jerk to make sure you don't trample eachothers work :) https://github.com/project-topaz/topaz/pull/1263

topaz-next-bot commented 3 years ago

Comment by rude-jerk Tuesday Oct 06, 2020 at 15:20:09

If someone merges this after the requested changes I'll handle resolving the conflict on my PR.

topaz-next-bot commented 3 years ago

Comment by zach2good Thursday Oct 08, 2020 at 04:55:20

Since there is only a little formatting to do, I'm going to merge this and then ninja in the formatting so @rude-jerk can continue with what he's doing. Thanks for the contribution! 👍

topaz-next-bot commented 3 years ago

Comment by zach2good Thursday Oct 08, 2020 at 05:02:31

Style changes here: https://github.com/project-topaz/topaz/commit/9b72cd2192efa1a5b4ffcaac3b7629177a9eda0e

topaz-next-bot commented 3 years ago

Comment by nsabott Thursday Oct 08, 2020 at 09:07:23

Sorry, I've been trying to get back to fixing this up, just got swamped with class work and haven't got the chance to fix up the formatting, my apologies :(.