topaz-next-bot
commented
3 years ago 
This is one of the many things I started on and never finished, https://github.com/TeoTwawki/darkstar/commit/9e8ca8f1b3d65e2c4d4a3d72c78da2c71f1af651
I despise gigantic if/else towers and massive switch statements, and was looking for a better way to code that when I discovered: we do "global" drops all kinds of wrong.
On dsp/topaz:
- crystals/seals/geode/avatarite/etc happen at a fixed rate if you meet the level requirement on an exp mob (with region+status effect for crystals)
- edit - if I am not mistaken there is also a timer to try and prevent seals from dropping "too often".
on retail:
- any unused "drop slot" can contain one of the eligible global drop items, on a per players basis allowing for example up to 6 crystals to drop from one mob IF you have a full party of 6 and the mobs drops left 6 open slots for them to fill. If a mob were to drop 10 things in 1 kill, no crystals seals or geodes could drop in the same kill. While killing another mob may push items out of your treasure pool and be "lot" no single mob kill will make an item that mob dropped be lost, it will just not drop any of the globals, and its non-global loot is grouped in a way that will never exceed the max pool size.
The issue I described need to be tackled before we can add these with any retail accuracy. I was tempted to just add them in mobs.lua using addTreasure() and if you want to add them to your server as a custom addition I suggest that route rather than using my old code I linked above, as its the shortest/simplest method. be aware however this bypasses the pool cap in the core and can cause treasure loss.
I have:
Additional Information (Steps to reproduce/Expected behavior) :
I know this has not been coded, so it's not really a bug per-se. But I am logging this issue to let people know that I am working on this atm. So we can start discussing before I submit the PR.
So far: This is about elemental geodes (snow geode, aqua geode, etc) AND the avatar geodes (ifritite, garudite, etc)
I have almost finished writing a log-parser for my retail logs to try to narrow the drop rate of those, for the thousands of mobs I have killed. I am using the Autoexec plugin to track the current weather when the mod dies.
Normal geodes drop from mobs 50+ Avatar geodes drop from mobs 80+ (not 100% sure about those 2 levels, still doing some tests)
When a weather is present, it has precedence and will determine which element the geode will be. Otherwise its the day element.