Knights Of Rotund WS for Excalipoor II (20714)

topaz-next / topaz

💎 A server emulator for Final Fantasy XI.

GNU General Public License v3.0

56 stars 81 forks source link

Knights Of Rotund WS for Excalipoor II (20714) #2153

Closed topaz-next-bot closed 3 years ago

topaz-next-bot commented 3 years ago

Issue by TeoTwawki Friday Oct 23, 2020 at 02:48:41 Originally opened as: project-topaz/topaz - Issue 1410

I affirm:

[x] that I agree to Project Topaz's Limited Contributor License Agreement, as written on this date
[x] that I've tested my code since the last commit in the PR, and will test after any later commits

Now you too can make Light at level one for amazingly gimp damage.

Excalipoor+1 not included. Not responsible for side effects that may include sudden weight gain, a rash, sneezing, itchy red eyes, incontinence, lost or misdirected mail, or an urge to /yell I haaaave the powerrrrrr!

topaz-next-bot commented 3 years ago

Comment by zach2good Friday Oct 23, 2020 at 06:28:37

I might be able to get you the information for excalipoor for the db so this can be an all-in-one PR, please hold for a day or so 👍

topaz-next-bot commented 3 years ago

Comment by TeoTwawki Friday Oct 23, 2020 at 06:35:54

Okies

topaz-next-bot commented 3 years ago

Comment by zach2good Friday Oct 23, 2020 at 20:06:28

When I added Nihility for reference; https://github.com/project-topaz/topaz/commit/13984d847277c7dfce6eb45649954bdd000af6bf#diff-1ae46b4dec5f3da0b65d817c19f83b927d563bd5afa95ebc6d6c5f82787fe2eeR10654

item_basic:
    (20713, 0, 'excalipoor', 'excalipoor', 1, 30784, 0, 1, 0),
    (20714, 0, 'excalipoor_ii', 'excalipoor_ii', 1, 30784, 0, 1, 0),
item_equipment:
    (20713, 'excalipoor', 1, 0, 4194303, 729, 0, 0, 3, 0),
    (20714, 'excalipoor_ii', 1, 0, 4194303, 729, 0, 0, 3, 0),
item_weapons:
    (20713, 'excalipoor', 3, 0, 0, 0, 0, 2, 1, 240, 1, 0),
    (20714, 'excalipoor_ii', 3, 0, 0, 0, 0, 2, 1, 233, 2, 0),

topaz-next-bot commented 3 years ago

Comment by TeoTwawki Friday Oct 23, 2020 at 22:44:16

@zach2good so turns out all 6 of those rows already exist with those exact values. I've now added the item mod row, which was all that was left.

I could have sworn I already added all of this back in DSP but when I saw the weaponskill row and script missing thought I must have been mistaken. Its half there half not there, only git blame knows for sure now.